Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve structure of Table tests #98

Closed
lars-reimann opened this issue Mar 27, 2023 · 2 comments · Fixed by #256
Closed

Improve structure of Table tests #98

lars-reimann opened this issue Mar 27, 2023 · 2 comments · Fixed by #256
Assignees
@robmeth @jxnior01 @daniaHu
Labels
released Included in a release testing 🧪 Additional automated tests

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Mar 27, 2023 •
edited
Loading

Regarding the tests of Table:

  • Rename tests so they start with test_should_
  • Use fixtures and parametrization to reduce code duplication
  • Add ids to parametrized tests
  • Cover everything (see this) - goal: 100% coverage

Use the tests for Row and Column as an example.
@lars-reimann lars-reimann added the testing 🧪 Additional automated tests label Mar 27, 2023
@lars-reimann lars-reimann changed the title Check all data tests Improve data tests Mar 27, 2023
@lars-reimann lars-reimann mentioned this issue Mar 27, 2023
Closed
@lars-reimann lars-reimann changed the title Improve data tests Improve structure of data tests Mar 30, 2023
This was referenced Apr 13, 2023
Closed
Closed
@lars-reimann lars-reimann self-assigned this Apr 23, 2023
@lars-reimann
Copy link
Member Author

Since Table and Column already have quite a few methods and will continue to grow, it makes sense to keep the structure we have now (one file per method, instead of one class per method).

@lars-reimann lars-reimann changed the title Improve structure of data tests Improve structure of Table tests Apr 23, 2023
@lars-reimann lars-reimann removed their assignment Apr 23, 2023
@robmeth robmeth mentioned this issue Apr 28, 2023
Merged
@robmeth robmeth linked a pull request Apr 28, 2023 that will close this issue
test: improve structure of table tests #256
Merged
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robmeth robmeth

@jxnior01 jxnior01

@daniaHu daniaHu

Labels
released Included in a release testing 🧪 Additional automated tests
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: improve structure of table tests Safe-DS/Library
4 participants
@lars-reimann @robmeth @jxnior01 @daniaHu