Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add lag-plot for time series #519

Closed
Tracked by #517
Gerhardsa0 opened this issue Jan 9, 2024 · 2 comments · Fixed by #548
Closed
Tracked by #517

feat: Add lag-plot for time series #519

Gerhardsa0 opened this issue Jan 9, 2024 · 2 comments · Fixed by #548
Labels
enhancement 💡 New feature or request released Included in a release

Comments

@Gerhardsa0
Copy link
Contributor

Gerhardsa0 commented Jan 9, 2024 •
edited
Loading

Is your feature request related to a problem?

When working with time series, a lag plot is useful to see correlation between values and time.
So when implementing this issue, the "lagging" itself must be implemented and the visualization.

Desired solution

The user should call something like this: ts.plot_lagplot()

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@Gerhardsa0 Gerhardsa0 added the enhancement 💡 New feature or request label Jan 9, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Library Jan 9, 2024
@Gerhardsa0 Gerhardsa0 mentioned this issue Jan 9, 2024
Open
4 tasks
@lars-reimann
Copy link
Member

Other plotting functions use the prefix plot_, so something like plot_lagplot would be appropriate. The first plot is a verb, while lagplot is the name of the plot.

@Gerhardsa0 Gerhardsa0 mentioned this issue Feb 20, 2024
Merged
@Gerhardsa0 Gerhardsa0 linked a pull request Feb 20, 2024 that will close this issue
feat: added plot_lagplot #548
Merged
Gerhardsa0 added a commit that referenced this issue Feb 20, 2024
@Gerhardsa0 @megalinter-bot
feat: added lag_plot (#548)
0fb38d2 
Closes #519 

### Summary of Changes
I added the visualization of the lag plot to the timeseries class
---------

Co-authored-by: megalinter-bot <129584137+megalinter-bot@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Backlog to ✔️ Done in Library Feb 20, 2024
lars-reimann pushed a commit that referenced this issue Apr 3, 2024
@semantic-release-bot
chore(release): 0.20.0 [skip ci]
98bccd0 
## [0.20.0](v0.19.0...v0.20.0) (2024-04-03)

### Features

* add deterministic hash methods to all types ([#573](#573)) ([f6a3ca7](f6a3ca7))
* add fnn functionality ([#529](#529)) ([ce53153](ce53153)), closes [#522](#522)
* add suffixes to models to indicate their task ([#588](#588)) ([d490dee](d490dee))
* added lag_plot ([#548](#548)) ([0fb38d2](0fb38d2)), closes [#519](#519)
* added normal plot for time series ([#550](#550)) ([dbdf11e](dbdf11e)), closes [#549](#549)
* when using from table to time series feature must be given ([#572](#572)) ([ca23f0f](ca23f0f)), closes [#571](#571)

### Bug Fixes

* incorrect type hint for `number_of_bins` parameter ([#567](#567)) ([b434e53](b434e53))
* mark various API elements as internal ([#587](#587)) ([ea176fc](ea176fc)), closes [#582](#582) [#585](#585)
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 💡 New feature or request released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added plot_lagplot Safe-DS/Library
2 participants
@lars-reimann @Gerhardsa0