feat: add deterministic hash methods to all types #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: add tests to all new hash implementations
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 50
Lines 2915 2956 +41
=========================================
+ Hits 2915 2956 +41 ☔ View full report in Codecov by Sentry. |
WinPlay02
changed the title
lars-reimann
requested changes
Mar 18, 2024
lars-reimann
pushed a commit
that referenced
this pull request
Apr 3, 2024
## [0.20.0](v0.19.0...v0.20.0) (2024-04-03) ### Features * add deterministic hash methods to all types ([#573](#573)) ([f6a3ca7](f6a3ca7)) * add fnn functionality ([#529](#529)) ([ce53153](ce53153)), closes [#522](#522) * add suffixes to models to indicate their task ([#588](#588)) ([d490dee](d490dee)) * added lag_plot ([#548](#548)) ([0fb38d2](0fb38d2)), closes [#519](#519) * added normal plot for time series ([#550](#550)) ([dbdf11e](dbdf11e)), closes [#549](#549) * when using from table to time series feature must be given ([#572](#572)) ([ca23f0f](ca23f0f)), closes [#571](#571) ### Bug Fixes * incorrect type hint for `number_of_bins` parameter ([#567](#567)) ([b434e53](b434e53)) * mark various API elements as internal ([#587](#587)) ([ea176fc](ea176fc)), closes [#582](#582) [#585](#585)
|
🎉 This PR is included in version 0.20.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
__hash__methods to the all types__eq__method toTaggedTableandTimeSeriesThe
__hash__-Implementation is needed to more efficiently check whether data may be the same.A deterministic implementation is used (based on
xxhash, a fast non-cryptographic hash algorithm) to allow these comparisons to be performed across different interpreters (processes).The implementation of the Schema was updated to be deterministic.