-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve structure of table tests #256
Conversation
…sts' into 98-improve-structure-of-table-tests
…sts' into 98-improve-structure-of-table-tests
…ws.py, and test_remove_columns.py
…sts' into 98-improve-structure-of-table-tests
…com/Safe-DS/Stdlib into 98-improve-structure-of-table-tests
…sts' into 98-improve-structure-of-table-tests
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov Report
@@ Coverage Diff @@
## main #256 +/- ##
===========================================
+ Coverage 0 100.00% +100.00%
===========================================
Files 0 44 +44
Lines 0 1705 +1705
===========================================
+ Hits 0 1705 +1705 |
Suggestion for the tests that check whether some error is raised: Instead of putting the type of the error in the name of the test, put the condition under which an error should be raised there. Example (for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice at first glance. The part
Cover everything (see this) - goal: 100% coverage
seems to be missing at the moment, though (based on the coverage of this PR).
I'll have a deeper look at everything once the linter passes and these remarks are fixed.
…com/Safe-DS/Stdlib into 98-improve-structure-of-table-tests
…com/Safe-DS/Stdlib into 98-improve-structure-of-table-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!
🎉 This PR is included in version 0.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Closes #98
Summary of Changes
Regarding the tests of
Table
:Rename tests so they start with
test_should_
Use fixtures and parametrization to reduce code duplication
Add
ids
to parametrized testsCover everything (see this) - goal: 100% coverage
Use the tests for
Row
andColumn
as an example.Co-authored-by: daniaHu 129186516+daniaHu@users.noreply.github.com
Co-authored-by: jxnior01 129027012+jxnior01@users.noreply.github.com