add arch param to CV Filter Rule

[sean797]

No description provided.

[coveralls]

Coverage remained the same at 97.668% when pulling 7e8d8d6 on sean797:cv-filter-arch into 8f2211a on SatelliteQE:master.

[oshtaier]

I am definitely see 'architecture': entity_fields.OneToOneField(Architecture) in application API:

architecture | package: architecture
optional       |  Validations:String

but see nothing that is similar to

'type': entity_fields.StringField(
    choices=('all', 'greater', 'equal', 'less', 'range'),
),

There is an erratum type variable, but it has other possible values:

types | erratum: types (enhancement, bugfix, security)
optional | Validations:Must be an array of any type

Choices provided by you looks more as a search criteria rather than entity possible variable

Do you use a new build? Or what was a source of information for that change?
Anyway, please provide console outputs of command execution for PR, so everyone can see what application returns and that no errors happen with these new changes

[sean797]

Sorry, I did add info about type to the commit message (copied below) note there is type and types param confusing I know,. :/

---

More info on this param can be found in https://github.com/Katello/katello/blob/cdc03f0836cde3b41675fd4df13cc96048c333af/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-views/details/filters/filter.factory.js#L29-L39

[oshtaier]

Thanks, I reviewed mentioned code
Still question is: Do we have application build where that code applied? And if we have, can you create rule using nailgun and provide output here? Like both GET and POST results as create() will subsequently call read()

[sean797]

I'm in the middle of creating an ansible module for CV filters. See sean797/foreman-ansible-modules@ec86dca which you are welcome to test.

[sean797]

@oshtaier okay if I remove type and we can merge this?
I don't strictly need type and would like this merged soon.

[sean797]

updated, thanks.

[san7ket]

I am facing issue with this,

In [56]: arch[0]
Out[56]: nailgun.entities.Architecture(id=1, name=u'x86_64')
In [57]: entities.ContentViewFilterRule(server,content_view_filter=acvf,architecture=arch[0],name='test_arch1',version='2').create()
Out[57]: nailgun.entities.ContentViewFilterRule(version=u'2', name=u'test_arch1', id=7, content_view_filter=nailgun.entities.AbstractContentViewFilter(repository=[], inclusion=False, content_view=nailgun.entities.ContentView(id=20), description=None, type=u'rpm', id=8, name=u'qnplZzsAtK'))

Production log:

2018-08-03T09:42:07 [I|app|] Started POST "/katello/api/v2/content_view_filters/8/rules" for 10.67.116.203 at 2018-08-03 09:42:07 -0400
2018-08-03T09:42:07 [I|app|a3ad2] Processing by Katello::Api::V2::ContentViewFilterRulesController#create as */*
2018-08-03T09:42:07 [I|app|a3ad2]   Parameters: {"version"=>"2", "architecture_id"=>1, "name"=>"test_arch1", "content_view_filter_id"=>"8", "api_version"=>"v2", "content_view_filter_rule"=>{"version"=>"2", "architecture_id"=>1, "name"=>"test_arch1", "content_view_filter_id"=>"8"}}
2018-08-03T09:42:07 [I|app|a3ad2] Current user: foreman_admin (administrator)
2018-08-03T09:42:07 [I|app|a3ad2] Authorized user admin(Admin User)
2018-08-03T09:42:07 [I|app|a3ad2] Current user: admin (administrator)
2018-08-03T09:42:07 [I|app|a3ad2]   Rendering /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.7.0.7/app/views/katello/api/v2/common/create.json.rabl within katello/api/v2/layouts/resource
2018-08-03T09:42:07 [I|app|a3ad2]   Rendered /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.7.0.7/app/views/katello/api/v2/common/create.json.rabl within katello/api/v2/layouts/resource (3.4ms)
2018-08-03T09:42:07 [I|app|a3ad2] Completed 200 OK in 50ms (Views: 4.4ms | ActiveRecord: 12.0ms)
2018-08-03T09:42:32 [I|app|] Started GET "/katello/api/v2/content_view_filters/8/rules" for 10.67.116.203 at 2018-08-03 09:42:32 -0400
2018-08-03T09:42:32 [I|app|01e85] Processing by Katello::Api::V2::ContentViewFilterRulesController#index as */*
2018-08-03T09:42:32 [I|app|01e85]   Parameters: {"content_view_filter_id"=>"8", "api_version"=>"v2", "content_view_filter_rule"=>{"content_view_filter_id"=>"8"}}
2018-08-03T09:42:33 [I|app|01e85] Current user: foreman_admin (administrator)
2018-08-03T09:42:33 [I|app|01e85] Authorized user admin(Admin User)
2018-08-03T09:42:33 [I|app|01e85] Current user: admin (administrator)
2018-08-03T09:42:33 [I|app|01e85]   Rendering /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.7.0.7/app/views/katello/api/v2/content_view_filter_rules/index.json.rabl within katello/api/v2/layouts/collection
2018-08-03T09:42:33 [I|app|01e85]   Rendered /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.7.0.7/app/views/katello/api/v2/content_view_filter_rules/index.json.rabl within katello/api/v2/layouts/collection (16.6ms)

Filter is not able to associate the arch, I also checked from UI.
Looks like even though controller doesn't complain about taking in "architecture_id"=>1 , it still needs architecture as String.
I guess this would be a product issue?

[sean797]

Thanks @san7ket I've updated to string, which I think it was originally.. Anyway:

>>> ContentViewFilterRule(server,content_view_filter=acvf,architecture='x86_64',name='bash').create()
nailgun.entities.ContentViewFilterRule(name=u'bash', id=11, architecture=u'x86_64', content_view_filter=nailgun.entities.AbstractContentViewFilter(repository=[], inclusion=True, content_view=nailgun.entities.ContentView(id=24), description=None, type=u'rpm', id=26, name=u'filer'))
>>> 

[san7ket]

@abalakh @ldjebran can you guys take a look

[ldjebran]

ACK

[ldjebran]

@sean797 many thanks.