add katello_content_view_filter module #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean797
force-pushed
the
cv-filter
branch
2 times, most recently
from
7292119 to
3f9abc2
Compare
sean797
force-pushed
the
cv-filter
branch
5 times, most recently
from
7164556 to
186c839
Compare
|
Depending PRs merged and tests passed 🎆 |
mdellweg
requested changes
Aug 7, 2018
| @@ -229,12 +233,12 @@ def update_fields(new, old, fields): | |||
|
|
|||
|
|
|||
| # Common functionality to manipulate entities | |||
| def naildown_entity_state(entity_class, entity_dict, entity, state, module): | |||
| changed, _ = naildown_entity(entity_class, entity_dict, entity, state, module) | |||
| def naildown_entity_state(entity_class, entity_dict, entity, state, module, check_missing=[]): | |||
There was a problem hiding this comment.
Mutable objects as default Argumnents are almost never, what you expect. Please use None here.
There was a problem hiding this comment.
I did it as it saves me having to check if it's iterable later, anyway updated.
mdellweg
approved these changes
Aug 14, 2018
|
Thanks @mdellweg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
SatelliteQE/nailgun#504SatelliteQE/nailgun#505SatelliteQE/nailgun#506SatelliteQE/nailgun#508Katello/katello#7560Katello/katello#7492I wasn't going to raise this until the above PRs were merged, but it seems the Nailgun ones, in particular, are taking a while. Anyone interested in testing this is welcome to use https://github.com/sean797/nailgun/tree/mix which has the 4 commits cherry-picked.