poll for task intended to fail #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Griffin-Sullivan
previously approved these changes
Jan 31, 2023
adamruzicka
reviewed
Feb 2, 2023
pondrejk
force-pushed
the
poll_failed_task
branch
from
065aaec to
8d1e757
Compare
|
@adamruzicka @Griffin-Sullivan comments addressed, mind revisiting? Thanks! |
Griffin-Sullivan
previously approved these changes
Feb 6, 2023
pondrejk
force-pushed
the
poll_failed_task
branch
from
8d1e757 to
608d2ab
Compare
|
@Gauravtalreja1 @Griffin-Sullivan mind revisiting? |
jyejare
approved these changes
Feb 9, 2023
jyejare
force-pushed
the
poll_failed_task
branch
from
608d2ab to
244b903
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Feb 9, 2023
(cherry picked from commit 905eb11)
Gauravtalreja1
pushed a commit
that referenced
this pull request
Feb 9, 2023
pondrejk
added a commit
to pondrejk/nailgun
that referenced
this pull request
May 24, 2023
Gauravtalreja1
pushed a commit
that referenced
this pull request
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
_poll_taskdid check if the task succeeded, which caused a problem for negative tests where we want wait on the task to finish but we expect failure. This pr adds a parameter to make this behavior configurable, the default is kept as it was, though no need to update existing callers.Functional demonstration
Will provide a robottelo pr using the parameter.
[update] see SatelliteQE/robottelo#10591