Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time-to-pickup tests for pull rex #10591

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

pondrejk
Copy link
Contributor

@pondrejk pondrejk commented Jan 31, 2023

tests for time-to-pickup setting introduced in 6.13 for pull-provider rex jobs

requires SatelliteQE/nailgun#888

@pondrejk pondrejk added the 6.13.z Introduced in or relating directly to Satellite 6.13 label Jan 31, 2023
@pondrejk pondrejk self-assigned this Jan 31, 2023
@pondrejk pondrejk added the CherryPick PR needs CherryPick to previous branches label Jan 31, 2023
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_remoteexecution.py -k pickup
nailgun: 888

@pondrejk pondrejk force-pushed the rex-pp-improvements branch 2 times, most recently from e84f4bf to 548cdc0 Compare February 1, 2023 14:10
@pondrejk
Copy link
Contributor Author

pondrejk commented Feb 1, 2023

trigger: test-robottelo
pytest: tests/foreman/api/test_remoteexecution.py -k pickup
nailgun: 888

1 similar comment
@pondrejk
Copy link
Contributor Author

pondrejk commented Feb 2, 2023

trigger: test-robottelo
pytest: tests/foreman/api/test_remoteexecution.py -k pickup
nailgun: 888

result = rhel_contenthost.execute('yggdrasil status')
assert result.status == 0, f'Failed to start yggdrasil on client: {result.stderr}'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just beware this is not as great indication as one could think

# yggdrasil status
Connection status for joint-jaybird.example.com:

● Connected to Red Hat Subscription Management
● The yggdrasil daemon is inactive

Manage your Red Hat connector systems: https://red.ht/connector

# echo $?
0

# systemctl status yggdrasild
● yggdrasild.service - yggdrasil daemon
   Loaded: loaded (/usr/lib/systemd/system/yggdrasild.service; enabled; vendor preset: disabled)
   Active: failed (Result: exit-code) since Thu 2023-02-02 08:40:22 EST; 1min 9s ago
     Docs: https://github.com/redhatinsights/yggdrasil
  Process: 849 ExecStart=/usr/sbin/yggdrasild (code=exited, status=1/FAILURE)
 Main PID: 849 (code=exited, status=1/FAILURE)

Feb 02 08:40:22 joint-jaybird.example.com systemd[1]: Started yggdrasil daemon.
Feb 02 08:40:22 joint-jaybird.example.com yggdrasild[849]: [yggdrasild] 2023/02/02 08:40:22 /builddir/build/BUILD/yggdrasil-0.2.0/cmd/yggd/main.go:155: starting yggdrasild version 0.2.0
Feb 02 08:40:22 joint-jaybird.example.com yggdrasild[849]: [yggdrasild] 2023/02/02 08:40:22 /builddir/build/BUILD/yggdrasil-0.2.0/cmd/yggd/main.go:200: listening on socket: @yggd-dispatcher-oIHvYx
Feb 02 08:40:22 joint-jaybird.example.com yggdrasild[849]: cannot connect to broker: network Error : dial tcp: lookup expert-earwig.example.com on 192.168.122.1:53: no such host
Feb 02 08:40:22 joint-jaybird.example.com systemd[1]: yggdrasild.service: Main process exited, code=exited, status=1/FAILURE
Feb 02 08:40:22 joint-jaybird.example.com systemd[1]: yggdrasild.service: Failed with result 'exit-code'.

robottelo/api/utils.py Outdated Show resolved Hide resolved
@pondrejk pondrejk force-pushed the rex-pp-improvements branch from 548cdc0 to 6c380ce Compare February 2, 2023 15:59
@pondrejk
Copy link
Contributor Author

pondrejk commented Feb 2, 2023

trigger: test-robottelo
pytest: tests/foreman/api/test_remoteexecution.py -k pickup
nailgun: 888

tests/foreman/api/test_remoteexecution.py Show resolved Hide resolved
tests/foreman/api/test_remoteexecution.py Show resolved Hide resolved
tests/foreman/api/test_remoteexecution.py Outdated Show resolved Hide resolved
tests/foreman/api/test_remoteexecution.py Outdated Show resolved Hide resolved
tests/foreman/api/test_remoteexecution.py Outdated Show resolved Hide resolved
@pondrejk pondrejk force-pushed the rex-pp-improvements branch from 6c380ce to df020e3 Compare February 6, 2023 12:16
@pondrejk pondrejk force-pushed the rex-pp-improvements branch from df020e3 to 654505b Compare February 6, 2023 12:50
@pondrejk
Copy link
Contributor Author

pondrejk commented Feb 6, 2023

trigger: test-robottelo
pytest: tests/foreman/api/test_remoteexecution.py -k pickup
nailgun: 888

@pondrejk
Copy link
Contributor Author

pondrejk commented Feb 6, 2023

Previous prt failures occurred because the job was using the default capsule with ssh provider to go around the lack of response form mqtt client, so the negative assert was not met. Latest push changes the global setting to disallow that.

From prt run 1773:

 + py.test tests/foreman/api/test_remoteexecution.py -k pickup --junit-xml=sat-results.xml -o junit_suite_name=sat-result
 ============================= test session starts ==============================
 platform linux -- Python 3.11.0, pytest-7.2.1, pluggy-1.0.0
 shared_function enabled - OFF - scope:  - storage: file
 rootdir: /opt/app-root/src/robottelo, configfile: pyproject.toml
 plugins: ibutsu-2.2.4, mock-3.10.0, reportportal-5.1.3, services-2.2.1, xdist-3.1.0
 collected 7 items / 1 deselected / 6 selected
 
 tests/foreman/api/test_remoteexecution.py ......                         [100%]

@shubhamsg199 @adamruzicka mind revisiting?

Copy link

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have anything to add, lgtm

Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants