Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding organization_id to ActivationKey entity #990

Closed

Conversation

ColeHiggins2
Copy link
Member

Description of changes

Adding organization_id to the ActivationKey entity

Upstream API documentation, plugin, or feature links

Robottelo PR: SatelliteQE/robottelo#12348

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4e4026f) 92.14% compared to head (99f4e8f) 92.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #990   +/-   ##
=======================================
  Coverage   92.14%   92.14%           
=======================================
  Files           6        6           
  Lines        3043     3043           
=======================================
  Hits         2804     2804           
  Misses        239      239           
Files Changed Coverage Δ
nailgun/entities.py 91.28% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -226,6 +226,7 @@ def __init__(self, server_config=None, **kwargs):
Organization,
required=True,
),
'organization_id': entity_fields.IntegerField(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's organization field already present, so not sure why organization_id field is required here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API was giving weird responses from what @ColeHiggins2 showed me when using org, but adding org_id helped.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me take a look at it. Nailgun itself should take care of including organization_id in the HTTP request.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ogajduse if you look at this response.
Received HTTP 404 response: {"displayMessage":"One of parameters [ organization_id ] required but not specified."

organization_id is not being passed in. Even when I played around with the existing organization entity. I could not get the ID from it.

@ogajduse
Copy link
Member

#992 is a more appropriate fix for this issue.

@sambible
Copy link
Contributor

Closing PR, it's been covered by #992

@sambible sambible closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z 6.14.z CherryPick PR needs CherryPick to previous branches fields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants