Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AK update must contain org id, it is a required field #992

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

lhellebr
Copy link
Contributor

@lhellebr lhellebr commented Sep 6, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (4e4026f) 92.14% compared to head (9956588) 92.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #992      +/-   ##
==========================================
+ Coverage   92.14%   92.15%   +0.01%     
==========================================
  Files           6        6              
  Lines        3043     3047       +4     
==========================================
+ Hits         2804     2808       +4     
  Misses        239      239              
Files Changed Coverage Δ
nailgun/entities.py 91.30% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Griffin-Sullivan
Copy link
Contributor

@ColeHiggins2 was this similar to the problem you had? Maybe you don't need to add an organization-id field?

@lhellebr lhellebr requested a review from a team September 7, 2023 06:57
@lhellebr
Copy link
Contributor Author

lhellebr commented Sep 7, 2023

trigger: test-robottelo
pytest: tests/foreman/api/test_permission.py::TestUserRole::test_positive_check_update

@adarshdubey-star
Copy link
Contributor

@lhellebr please check the build failure so that we can get this in.

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_permission.py::TestUserRole::test_positive_check_update

@jyejare jyejare merged commit 7bc1a11 into SatelliteQE:master Sep 12, 2023
8 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
* AK update must contain org id, it is a required field

* Test for AK update

(cherry picked from commit 7bc1a11)
ogajduse pushed a commit that referenced this pull request Sep 12, 2023
* AK update must contain org id, it is a required field

* Test for AK update

(cherry picked from commit 7bc1a11)
ColeHiggins2 pushed a commit to ColeHiggins2/nailgun that referenced this pull request Oct 3, 2023
* AK update must contain org id, it is a required field

* Test for AK update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants