improved webhook event trigger test

[pondrejk]

Problem Statement

Webhook trigger is blocked by the safemode setting enabled, which is expected as the safemode prevents template rendering which is prerequisite for webhook trigger.

The existing test didn't see this as it was looking just for one specific line in logs, so it passed even though no action was triggered.

Solution

This PR disables the safemode setting for the test so that the task is actually triggers. Also it adds a check for the successful completion of the triggered task.

[pondrejk]

trigger: test-robottelo
pytest: tests/foreman/api/test_webhook.py -k triggered

[jameerpathan111]

LGTM

[Griffin-Sullivan]

I don't completely understand what the setting change does, but it looks good to me. When I originally wrote this test I just was making sure the webhook event was triggering something in the log.

[Griffin-Sullivan]

Also is there a reason this is marked for T2 review also?

[pondrejk]

@Griffin-Sullivan safemode kind of protects users from doing something destructive with their ERB templates, https://access.redhat.com/documentation/en-us/red_hat_satellite/6.14/html/administering_red_hat_satellite/administration_settings_admin (section A11), it's on by default. T2 was there before, I just kept it

[pondrejk]

trigger: test-robottelo
pytest: tests/foreman/api/test_webhook.py -k triggered

[pondrejk]

ugh, after move from entities.Webhook to target_sat.api.Webhook this now fails with TypeError: Webhooks.__init__() got multiple values for argument 'server_config'

[omkarkhatavkar]

trigger: test-robottelo
pytest: tests/foreman/api/test_webhook.py -k triggered
nailgun: 1029

[omkarkhatavkar]

trigger: test-robottelo
pytest: tests/foreman/api/test_webhook.py -k triggered
nailgun: 1029
pod_resources_size: large

[pondrejk]

trigger: test-robottelo
pytest: tests/foreman/api/test_webhook.py -k triggered

[omkarkhatavkar]

trigger: test-robottelo
pytest: tests/foreman/api/test_webhook.py -k triggered
pod_resources_size: large

[pondrejk]

trigger: test-robottelo
pytest: tests/foreman/api/test_webhook.py -k triggered
pod_resources_size: large

[pondrejk]

The prt fails with the TypeError as before, seems like it doesn't take into account the nailgun fix by @omkarkhatavkar ?

[omkarkhatavkar]

trigger: test-robottelo
pytest: tests/foreman/api/test_webhook.py -k triggered
nailgun: 1029
pod_resources_size: large

[omkarkhatavkar]

The prt fails with the TypeError as before, seems like it doesn't take into account the nailgun fix by @omkarkhatavkar ?

https://github.com/SatelliteQE/robottelo/actions/workflows/update_robottelo_image.yml is failing.

[pondrejk]

yay! thanks for the quick turnaround @omkarkhatavkar