Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for webhook event trigger test #13170

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

pondrejk
Copy link
Contributor

Problem Statement

#13048 didn't get things 100% right, my apologies.

Solution

Adding an existing target url the webhook can actually GET from to succeed

Related Issues

This will need to get to 6.15 and 6.14. The 6.13 cherry-pick of #13048 didn't happen yet, I will create a manual cherry-pick for it + changes from this pr.

@pondrejk pondrejk added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Nov 23, 2023
@pondrejk pondrejk requested review from a team November 23, 2023 12:28
@pondrejk pondrejk self-assigned this Nov 23, 2023
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_webhook.py -k event_triggered

@Gauravtalreja1 Gauravtalreja1 added the Easy Fix :) Easiest Fix to review and quick merge request. label Nov 28, 2023
@Gauravtalreja1 Gauravtalreja1 enabled auto-merge (squash) November 28, 2023 07:08
@Gauravtalreja1 Gauravtalreja1 merged commit bb23504 into SatelliteQE:master Nov 28, 2023
11 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 28, 2023
github-actions bot pushed a commit that referenced this pull request Nov 28, 2023
pondrejk added a commit that referenced this pull request Nov 28, 2023
pondrejk added a commit that referenced this pull request Nov 28, 2023
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants