-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default content type as yum for make_repository helper #13196
Merged
omkarkhatavkar
merged 1 commit into
SatelliteQE:master
from
Gauravtalreja1:fix-make-repo-content-type
Nov 29, 2023
Merged
Add default content type as yum for make_repository helper #13196
omkarkhatavkar
merged 1 commit into
SatelliteQE:master
from
Gauravtalreja1:fix-make-repo-content-type
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
Gauravtalreja1
added
Easy Fix :)
Easiest Fix to review and quick merge request.
CherryPick
PR needs CherryPick to previous branches
AutoMerge_Cherry_Picked
The cherrypicked PRs of master PR would be automerged if all checks passing
6.15.z
Introduced in or relating directly to Satellite 6.15
labels
Nov 28, 2023
trigger: test-robottelo |
synkd
approved these changes
Nov 28, 2023
Griffin-Sullivan
approved these changes
Nov 28, 2023
vsedmik
approved these changes
Nov 28, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com> (cherry picked from commit c8429aa)
Gauravtalreja1
added a commit
that referenced
this pull request
Nov 29, 2023
This was referenced Nov 30, 2023
jyejare
pushed a commit
to jyejare/robottelo
that referenced
this pull request
Nov 30, 2023
…QE#13196) Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
jyejare
pushed a commit
to jyejare/robottelo
that referenced
this pull request
Nov 30, 2023
…QE#13196) Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
jyejare
pushed a commit
to jyejare/robottelo
that referenced
this pull request
Nov 30, 2023
…QE#13196) Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
jyejare
pushed a commit
to jyejare/robottelo
that referenced
this pull request
Nov 30, 2023
…QE#13196) Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
Gauravtalreja1
added a commit
that referenced
this pull request
Nov 30, 2023
* Remove cli.factory dependencies from the repo (#11544) Remove cli_factory * Add default content type as yum for make_repository helper (#13196) Signed-off-by: Gaurav Talreja <gtalreja@redhat.com> --------- Signed-off-by: Gaurav Talreja <gtalreja@redhat.com> Co-authored-by: Shweta Singh <shwsingh@redhat.com> Co-authored-by: Gaurav Talreja <gtalreja@redhat.com>
Gauravtalreja1
added a commit
that referenced
this pull request
Nov 30, 2023
* Remove cli.factory dependencies from the repo (#11544) Remove cli_factory * Add default content type as yum for make_repository helper (#13196) Signed-off-by: Gaurav Talreja <gtalreja@redhat.com> --------- Signed-off-by: Gaurav Talreja <gtalreja@redhat.com> Co-authored-by: Shweta Singh <shwsingh@redhat.com> Co-authored-by: Gaurav Talreja <gtalreja@redhat.com>
Gauravtalreja1
added a commit
that referenced
this pull request
Nov 30, 2023
* Remove cli.factory dependencies from the repo (#11544) Remove cli_factory * Add default content type as yum for make_repository helper (#13196) Signed-off-by: Gaurav Talreja <gtalreja@redhat.com> --------- Signed-off-by: Gaurav Talreja <gtalreja@redhat.com> Co-authored-by: Shweta Singh <shwsingh@redhat.com> Co-authored-by: Gaurav Talreja <gtalreja@redhat.com>
shweta83
pushed a commit
to shweta83/robottelo
that referenced
this pull request
Apr 10, 2024
…QE#13196) Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.15.z
Introduced in or relating directly to Satellite 6.15
AutoMerge_Cherry_Picked
The cherrypicked PRs of master PR would be automerged if all checks passing
CherryPick
PR needs CherryPick to previous branches
Easy Fix :)
Easiest Fix to review and quick merge request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Changes introduced in #11544 removed the usage of old cli.factory in favor of new cli_factory helpers. And, I've observed a few failures related default content_type missing from
hammer repository create
command used by make_repository helper, and it was present earlier and missing in cli_factory method.Solution
Add content_type=yum as default in make_repository helper of cli_factory
Additional Info
#11544 cherrypicking was failed for 6.14.z or older, but it was merged before branching, so this will require cherrypicking to 6.15.z