Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] Add default content type as yum for make_repository helper #13204

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #13196

Problem Statement

Changes introduced in #11544 removed the usage of old cli.factory in favor of new cli_factory helpers. And, I've observed a few failures related default content_type missing from hammer repository create command used by make_repository helper, and it was present earlier and missing in cli_factory method.

robottelo.exceptions.CLIFactoryError: Failed to create Repository with data:
{ 'http-proxy-policy': 'none',
  'name': 'sissapUBCf',
  'organization-id': 3,
  'product-id': '1',
  'url': 'http://testserver.example.com:50123/fake_yum0'}
Command "repository create" finished with status 64
stderr contains:
Could not create the repository:
  Missing arguments for '--content-type'.

Solution

Add content_type=yum as default in make_repository helper of cli_factory

Additional Info

#11544 cherrypicking was failed for 6.14.z or older, but it was merged before branching, so this will require cherrypicking to 6.15.z

Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
(cherry picked from commit c8429aa)
@Satellite-QE Satellite-QE requested a review from a team as a code owner November 29, 2023 06:35
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Nov 29, 2023
@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Nov 29, 2023
@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/cli/test_logging.py::test_positive_logging_from_pulp3 tests/foreman/cli/test_http_proxy.py::test_positive_assign_http_proxy_to_

@jyejare
Copy link
Member

jyejare commented Nov 29, 2023

@Gauravtalreja1 Looks like you missed the part of a test case name! Please update it !

@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/cli/test_logging.py::test_positive_logging_from_pulp3 tests/foreman/cli/test_http_proxy.py::test_positive_assign_http_proxy_to_products

Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack pending PRT

@Gauravtalreja1
Copy link
Collaborator

PRT trying to checkout 6.15.z which isn't available yet, so will merge this as easyfix.

@Gauravtalreja1 Gauravtalreja1 merged commit 503f5e5 into 6.15.z Nov 29, 2023
12 of 14 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.15.z-c8429aa9a2f67c90a27193cdc082b79c313c233a branch November 29, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants