Fix iOS 14.2 #7
Merged
Fix iOS 14.2 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SatoTakeshiX
commented
Mar 21, 2021
Comment on lines
-9
to
-12
| HStack { | ||
| ChildView(counter: $counter) | ||
| .frame(width: .infinity) | ||
| } |
SatoTakeshiX
commented
Mar 21, 2021
| @@ -8,7 +8,7 @@ final class DataSource: ObservableObject { | |||
| } | |||
|
|
|||
| struct ParentView: View { | |||
| @StateObject var dataSource = DataSource() | |||
| @StateObject private var dataSource = DataSource() | |||
There was a problem hiding this comment.
@StateObjectのプロパティにprivate追加
SatoTakeshiX
commented
Mar 21, 2021
Comment on lines
+30
to
+33
| GeometryReader { geometry in | ||
| FilterBannerView(isShowBanner: $viewModel.isShowBanner, applyingFilter: $viewModel.applyingFilter, bottomSafeAreaInsets: geometry.safeAreaInsets.bottom) | ||
| .edgesIgnoringSafeArea(.bottom) | ||
| } |
There was a problem hiding this comment.
iOS 14.2からbottomSafeAreaInsetsは親ビューから渡さないといけなくなったよう
SatoTakeshiX
commented
Mar 21, 2021
| @@ -11,7 +11,7 @@ import SafariServices | |||
|
|
|||
| struct SafariView: UIViewControllerRepresentable { | |||
| typealias UIViewControllerType = SFSafariViewController | |||
| var url: URL | |||
| let url: URL | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS 14.2からFilter SampleのバナーがSafe Areaをはみ出てしまっていたので修正
その他不具合修正
FilterBannerView