Sites: Estimate terrain objects bounding box overlap with site for hiding rocks etc #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding rocks etc. TL;DR stop mortars spawning inside rocks by removing ROCK/ROCKS/HIDE terrain objects with a bounding box estiamtion. Estimates whether nearby terrain objects will overlap/intersect with the spawned site, then hides them. Also hides any terrain objects directly on top of those found with bounding box search, otherwise we end up with a bunch of floating bushes. Can be expanded to other kinds of terrain objects on a per site basis. Requires more testing on my end for both functionality and performance ... so putting up as a draft PR for now.
|
Please can someone confirm that Did a $ find . -name "*.sqf" -exec grep -Hn 'call para_s_fnc_profile_db' {} \; | grep sites
./mission/functions/systems/sites/fn_sites_load.sqf:19:(["GET", "sites", []] call para_s_fnc_profile_db) params ["","_sitesData"]; |
dijksterhuis
commented
Oct 4, 2024
| }; | ||
| }; | ||
|
|
||
| _objsIntersectTerrainObjectsBBox |
There was a problem hiding this comment.
👀 this is definitely wrong and needs fixing.
veteran29
reviewed
Oct 6, 2024
| private _pos = [_center, _sizeMax / 4, _sizeMax / 2] call _fnc_findPos; | ||
|
|
||
| [_pos] call vn_mf_fnc_sites_create_aa_site; | ||
| [_pos, 5] call vn_mf_fnc_sites_hide_terrain_objects_bbox_intersections; |
There was a problem hiding this comment.
Is this part of MF code scheduled? If it is you should hide terrain objects before spawning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR stop mortars spawned inside rocks soft locking a zone by removing ROCK/ROCKS/HIDE terrain objects with a bounding box estimation.
Estimates whether nearby terrain objects will overlap/intersect with the spawned site, then hides them. Also hides any terrain objects directly on top of those found with bounding box search, otherwise we end up with a bunch of floating bushes. Can be expanded to other kinds of terrain objects on a per site basis.
Requires more testing on my end for both functionality and performance ... so putting up as a draft PR for now.
TODO
getDiron terrain objects to more accurately calculate overlap/intersections (rectangular area instead of circular?)clippingTypeargument forboundingBoxRealhttps://community.bistudio.com/wiki/boundingBoxRealscreenshots
notes about screenshots
_siteRadiusfor this example would have been 15, not 5.nearestTerrainObjectsmight want yet another bounding box calculationdebug markers
terrain hiding