Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with VERSION=local version override with all images #1

Closed
mtscout6 opened this issue Nov 17, 2014 · 1 comment
Closed

Build with VERSION=local version override with all images #1

mtscout6 opened this issue Nov 17, 2014 · 1 comment
Labels
D-defect help wanted

Comments

@mtscout6
Copy link
Member

Initial issue derived from elgalu/docker-selenium#8

The README gives directions to build the images locally by using a local version tag. This unfortunately does not work, because the FROM field in each Dockerfile is version specific.
@elgalu elgalu mentioned this issue Nov 17, 2014
Closed
@ghost
Copy link

ghost commented Jun 9, 2015

Yep, I see the bug. We'll need generate step to modify the FROM line with the proper VERSION requested when running make.

@ghost ghost self-assigned this Jun 9, 2015
ghost pushed a commit that referenced this issue Jun 9, 2015
FROM field in each Dockerfile is version specific
2412f6b 
fix issue #1

example:
VERSION=local make ball

should build all Dockerfile FROM field with 'local' tag
@ghost ghost mentioned this issue Jun 9, 2015
Merged
@ghost ghost closed this as completed Jun 11, 2015
@eyal919 eyal919 mentioned this issue Jan 4, 2016
Closed
@ddavison ddavison mentioned this issue Oct 14, 2016
Closed
@thyagab thyagab mentioned this issue Feb 16, 2017
Closed
@arpadcseh arpadcseh mentioned this issue Feb 23, 2017
Closed
@alinpa alinpa mentioned this issue Jun 7, 2018
Closed
@louyu65 louyu65 mentioned this issue Nov 19, 2018
Closed
@lock lock bot locked and limited conversation to collaborators Aug 14, 2019
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
D-defect help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mtscout6