Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid: secure 0mq #7856

Closed
adamgoucher opened this issue Dec 8, 2019 · 7 comments · Fixed by #8698
Closed

Grid: secure 0mq #7856

adamgoucher opened this issue Dec 8, 2019 · 7 comments · Fixed by #8698
Assignees
Labels

Comments

@adamgoucher
Copy link
Contributor

The default 0mq event bus should be able to be secured via configuration.

@diemol
Copy link
Member

diemol commented Apr 21, 2020

@adamgoucher Could you please provide some hints on how can this be implemented? Next steps?

@adamgoucher
Copy link
Contributor Author

adamgoucher commented Apr 21, 2020 via email

@adamgoucher
Copy link
Contributor Author

adamgoucher commented Aug 13, 2020

Further clarifications (since I've got busy and my placeholder for myself is only useful to myself). If memory serves, we are using https://github.com/zeromq/jeromq as the java 0mq implementation. It supports 'curve' security (http://curvezmq.org/). The idea here is that if someone gives the various components certificates to run the webdriver protocol over https, that they also be used to secure communication between the various components and 0mq. (If they don't set the certificate, then they will be sending all their commands via http, so it makes little sense to go through the hassle of setting up secure internal communication.)

From the jzeromq project, here are some links to show the implementation of it;

@raju249
Copy link
Member

raju249 commented Sep 14, 2020

@adamgoucher Are you working on this or Can I pick this issue to work?

@raju249 raju249 assigned raju249 and unassigned adamgoucher Sep 14, 2020
@raju249
Copy link
Member

raju249 commented Sep 14, 2020

@adamgoucher @diemol I am picking up this issue.

Thanks!

@shs96c
Copy link
Member

shs96c commented Sep 24, 2020

I had to back out this change because it was causing the EndToEndTest to fail.

@shs96c shs96c reopened this Sep 24, 2020
@AutomatedTester
Copy link
Member

AutomatedTester commented Sep 24, 2020 via email

@AutomatedTester AutomatedTester linked a pull request Sep 30, 2020 that will close this issue
8 tasks
@diemol diemol closed this as completed in 0c6c62b Oct 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants