Add sever and client keys to eventbus #8698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shs96c
reviewed
Sep 16, 2020
|
|
||
| import javax.swing.plaf.ColorUIResource; |
There was a problem hiding this comment.
Looks like a mistaken import. Please remove.
There was a problem hiding this comment.
Thanks @shs96c !
Removed the unused import.
For the question: I assumed the same. @adamgoucher can shed some light?
There was a problem hiding this comment.
I don't think so. the 0mq bus is something we control 100% and this is just a secure default. (I expect most large implementations will use a different bus anyways)
shs96c
added a commit
that referenced
this pull request
Sep 21, 2020
This reverts commit b03e108. This is because it caused the EndToEndTest to fail, which means we can't actually spin up a Grid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #7856
Motivation and Context
We had an unsecured implementation of zeromq, this PR adds security by using the CurveMQ server and client keys and certificates.
Types of changes
Checklist