Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login from code #1301

Merged
merged 5 commits into from
May 12, 2021
Merged

Login from code #1301

merged 5 commits into from
May 12, 2021

Conversation

taki9
Copy link
Contributor

@taki9 taki9 commented Apr 22, 2021

No description provided.

@taki9 taki9 self-assigned this Apr 22, 2021
@sensenet
Copy link

sensenet bot commented Apr 22, 2021

Site name Url Last deploy
sn-react-component-docs-dev https://609ab5d1abddeb5001ec14f7--sn-react-component-docs-dev.netlify.app Tue May 11 2021 - 16:50:26 GMT+0000 (Coordinated Universal Time)
sn-app-dev https://609ab5ca608fd92995c5b1c1--sn-app-dev.netlify.app Tue May 11 2021 - 16:50:19 GMT+0000 (Coordinated Universal Time)

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #1301 (07ca80f) into develop (bacc189) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1301      +/-   ##
===========================================
+ Coverage    93.50%   93.52%   +0.01%     
===========================================
  Files          232      233       +1     
  Lines         6317     6331      +14     
  Branches      1676     1681       +5     
===========================================
+ Hits          5907     5921      +14     
  Misses         410      410              
Impacted Files Coverage Δ
...ges/sn-authentication-oidc-react/src/code-login.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bacc189...07ca80f. Read the comment docs.

Copy link
Contributor

@enikonemeth enikonemeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some problems during test the examples:

DMS: has a problem with history.goBack() in runtime (in DmsViewer.tsx) it should be: history.go(-1) [fixed in https://github.com//pull/1299/files]
does not work login from code here (I had to type username + password)

sn-react-browser, sn-react-calendar and I think any other examples:
./src/components/app-providers.tsx
Attempted import error: 'codeLogin' is not exported from '@sensenet/authentication-oidc-react'.
steps:
root: yarn && yarn build
in example folder: npm install && npm start

@enikonemeth enikonemeth self-requested a review May 7, 2021 07:45
Copy link
Contributor

@enikonemeth enikonemeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working fine 👍

@taki9 taki9 merged commit 681db28 into develop May 12, 2021
@taki9 taki9 deleted the feature/login_from_code branch May 12, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants