Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken action on content name w parenthesis #1395

Merged
merged 7 commits into from
Jun 10, 2022

Conversation

VargaJoe
Copy link
Contributor

No description provided.

@sensenet
Copy link

sensenet bot commented Mar 25, 2022

Site name Url Last deploy
sn-app-dev https://62a3001b112b1105ec447243--sn-app-dev.netlify.app Fri Jun 10 2022 - 08:26:08 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://62a300257fde1e05e855f586--sn-react-component-docs-dev.netlify.app Fri Jun 10 2022 - 08:26:17 GMT+0000 (Coordinated Universal Time)

@VargaJoe
Copy link
Contributor Author

VargaJoe commented Mar 28, 2022

Check former getParentPath issue (#949)

@VargaJoe
Copy link
Contributor Author

VargaJoe commented Mar 30, 2022

Helpers like getSegments and isItemPath are used by getContentUrlByPath and while the former one does not handle id format, the other on tries to. I suggest to remove id handling from isItemPath too and make the logic consistent between the two helper.

Id only works in /OData.svc/Content(id) format and id can not be used everywhere in the path. If /Root is in the path id will definitely not work. It's a feature not a bug. Url by id is handled by getContentUrlbyId anyway which does not use the segments logic.

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #1395 (c8679c3) into develop (2332398) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1395   +/-   ##
========================================
  Coverage    92.28%   92.28%           
========================================
  Files          246      246           
  Lines         6843     6843           
  Branches      1816     1815    -1     
========================================
  Hits          6315     6315           
  Misses         528      528           
Impacted Files Coverage Δ
packages/sn-client-utils/src/path-helper.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2332398...c8679c3. Read the comment docs.

@VargaJoe VargaJoe self-assigned this Jun 8, 2022
@VargaJoe VargaJoe marked this pull request as ready for review June 9, 2022 14:00
@VargaJoe VargaJoe merged commit 406523f into develop Jun 10, 2022
@VargaJoe VargaJoe deleted the bugfix/parenthesis-in-name branch June 10, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants