Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getParentPath with content name like Test(1) #949

Merged
merged 7 commits into from
Oct 9, 2020
Merged

Fix getParentPath with content name like Test(1) #949

merged 7 commits into from
Oct 9, 2020

Conversation

enikonemeth
Copy link
Contributor

@enikonemeth enikonemeth commented Sep 25, 2020 •
edited
Loading

This PR solves both:

#940
#941

@enikonemeth enikonemeth added this to the Sprint 219 milestone Sep 25, 2020
@enikonemeth enikonemeth self-assigned this Sep 25, 2020
@sensenet
Copy link

sensenet bot commented Sep 25, 2020 •
edited
Loading

Site name Url Last deploy
sn-react-component-docs-dev https://5f80076ebe79c5180a325198--sn-react-component-docs-dev.netlify.app Fri Oct 09 2020 - 06:47:38 GMT+0000 (Coordinated Universal Time)
sn-app-dev https://5f800788befcd7186881a7d8--sn-app-dev.netlify.app Fri Oct 09 2020 - 06:47:38 GMT+0000 (Coordinated Universal Time)

@codecov
Copy link

codecov bot commented Sep 25, 2020 •
edited
Loading

Codecov Report

Merging #949 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #949   +/-   ##
========================================
  Coverage    92.25%   92.25%           
========================================
  Files          217      217           
  Lines         5923     5923           
  Branches      1519     1519           
========================================
  Hits          5464     5464           
  Misses         459      459
Impacted Files Coverage Δ
packages/sn-client-utils/src/path-helper.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b643a16...0310fb7. Read the comment docs.

@enikonemeth enikonemeth marked this pull request as draft September 25, 2020 14:56
@enikonemeth enikonemeth marked this pull request as ready for review September 25, 2020 15:10
@herflis herflis removed this from the Sprint 219 milestone Sep 30, 2020
@herflis herflis mentioned this pull request Oct 5, 2020
Closed
@enikonemeth enikonemeth merged commit c36416c into develop Oct 9, 2020
@enikonemeth enikonemeth deleted the fix/wrong_path branch October 9, 2020 07:01
aslafy-z pushed a commit to aslafy-z/sn-client that referenced this pull request Oct 24, 2020
@aslafy-z
Fix getParentPath with content name like Test(1) (SenseNet#949)
5ee604b 
* fix getParentPath with content name like Test(1)

* fix isItemSegment

* fix isItemSegment part2

* change the result of content(12) path
@VargaJoe VargaJoe mentioned this pull request Mar 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taki9 taki9 taki9 approved these changes

@herflis herflis herflis approved these changes

Assignees

@enikonemeth enikonemeth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enikonemeth @herflis @taki9