Skip to content
This repository has been archived by the owner on May 3, 2020. It is now read-only.

upgrade by installing deb will overwrite config.json #407

Open
anantshri opened this issue Jan 30, 2018 · 2 comments
Open

upgrade by installing deb will overwrite config.json #407

anantshri opened this issue Jan 30, 2018 · 2 comments

Comments

@anantshri
Copy link

The current deb includes config.json in it which effectively will overwrite the existing config.json. Either we need to provide a customization option or we need to remove config.json.

We also need to figure out how new user will get config.json for the first time. ideal location could be in post install script. just adding a clause to copy over config.json.defaults to config.json in case it doesn't already exist should sort the issue out.

@schrnz
Copy link

schrnz commented Feb 6, 2018

Totally agree. The problem is that config.json was committed once and now its entry in .gitignore does not help anymore.
Btw scripts/first_time.rb does exactly what you ask for, it copies over config.json.defaults.
Related: #400

@BuffaloWill
Copy link
Contributor

The updates to first_time.rb in @schrnz's PR should fix this. Apologies again @anantshri, we never intend to be destructive with user's data.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants