Reduce redundant else-branching (after throws), add missing @throws annotations #104
Conversation
library/Zend/Amf/Server.php
Outdated
| * @param string $method Is the method to execute | ||
| * @param mixed $param values for the method | ||
| * @param string $method Is the method to execute | ||
| * @param null $params |
There was a problem hiding this comment.
Params is mixed nullable with a default of null, not sure about source. I would put it as mixed or null|mixed
There was a problem hiding this comment.
Though i agree that declaring nullability explicitly might be helpful, to my understanding, null is one of the types included in "mixed".
See: https://wiki.php.net/rfc/mixed-typehint
There was a problem hiding this comment.
Fair enough, feel free to change it to just mixed then
Correct misspelled argument name, as discussed in https://github.com/Shardj/zf1-future/pull/104/files/5e8bb2ea2c9c574a81fdd3835abd36ecef9298aa#r484983369
Update Server.php
|
Was that finding accidental or after running some more thorough inspection? Another thought: Do you consider tackling the suggestion from Issue #96? |
|
I gave the change a quick skim through, so accidental. However once I found that one I did look for others and couldn't see any further problems I'm not planning on merging with #96 at all |
|
Thanks for your feedback. |
|
Thank you for merging 👍 |
| @@ -161,6 +161,7 @@ public function __construct($mimetype) | |||
| * magic file. | |||
| * | |||
| * @return string | |||
| * @throws Zend_Validate_Exception | |||
There was a problem hiding this comment.
this throws is bogus, it's never thrown (but caught and ignored silently)
will be removed when porting zf1s/zf1#54
| * @return array | ||
| * @throws Zend_Cloud_QueueService_Exception | ||
| */ | ||
| public function fetchQueueMetadata($queueId, $options = null) |
There was a problem hiding this comment.
this method also returns false.
| @@ -348,7 +340,8 @@ public static function escape($keyword) | |||
| * @param string $strQuery | |||
| * @param string $encoding | |||
| * @return Zend_Search_Lucene_Search_Query | |||
| * @throws Zend_Search_Lucene_Search_QueryParserException | |||
There was a problem hiding this comment.
Zend_Search_Lucene_Search_QueryParserException is still thrown in parse()
| @@ -709,8 +722,9 @@ public function getRequest() | |||
| /** | |||
| * Public access method to private Zend_Amf_Server_Response reference | |||
| * | |||
| * @param string|Zend_Amf_Server_Response $response | |||
| * @param string|Zend_Amf_Server_Response $response | |||
There was a problem hiding this comment.
Zend_Amf_Server_Response class does not exist:
No description provided.