Add missing @throws annotations #140
Conversation
Cherry-picked Shardj/zf1-future@5e8bb2e Cherry-picked Shardj/zf1-future@5997d40 Co-authored-by: Elan Ruusamäe <glen@pld-linux.org>
|
@falkenhawk such trivial change which you approved in words but still not merged? I had some idea to carry changes from zf1-future, but if the process is blocked such trivial changes, it really demotivates and questions should this fork just be marked abandoned. or increase the developer team size who can actually approve and merge things? |
|
@glensc I appreciate your expression of disappointment, I'd love to be more involved, and also we have few people in the team with access to push/create pull requests/reviews, but it is not trivial to just allocate time to manage it. (or to find enough motivation) I guess your comment was meant to be a motivational one, but it is difficult not to take it personal. I want to believe that perhaps you are affected by not having a particularly great day today, or maybe it is just me, being a bit vulnerable by not having a good time at this moment either. Not actioning on the repo for past 4 weeks is far from abandoning it, I would say. |
and it is not only your PR, as you may see also PRs created by me myself are not merged yet. (also small and trivial ones) and a bigger one (i.e. #141 ) still awaits a free time slot in one's free time to take care of. Anyway, I should not even feel pushed to spend my time on writing such comments. could we try to encourage each other (as I've been always trying to by even commenting with a word of appreciation on every issue and PR created here) and put toxicity aside, please. |
There was a problem hiding this comment.
Aside from the comments above, thanks a lot for setting up this PR, as discussed in #138 to avoid additional code structure changes which are not necessary in our approach, I really appreciate it.
As you probably saw I could've only put a heart emoji on the PR description before forgetting about it and proceeding with my daily chores. So indeed this PR needed a reminder to get my attention back, and to merge it after pending for 26 days since it was created
Carry only
@throwsannotations from #138Which itself was to carry Shardj/zf1-future#104:
cc @kstenschke