Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

Add dynamic dispatch #18

Merged
merged 3 commits into from
Mar 14, 2022
Merged

Add dynamic dispatch #18

merged 3 commits into from
Mar 14, 2022

Conversation

myakhnis-shopify
Copy link

@myakhnis-shopify myakhnis-shopify commented Mar 14, 2022 •
edited
Loading

Fixes https://github.com/Shopify/oxygen-dms/issues/426

Changes:

  • Added WorkerDynamicDispatchBinding and associated type + methods
  • Added etag_bypass to response info

@myakhnis-shopify
added dd binding
34ca0c8 
cleanup

updated dd binding

added etag bypass

added dd test
GustavoCaso
GustavoCaso approved these changes Mar 14, 2022
View reviewed changes
Copy link

@GustavoCaso GustavoCaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to include the new binging type on the switch case inside the ListWorkerBindings and update the test.

A part from that awesome work 🎉

@myakhnis-shopify myakhnis-shopify merged commit 53afb2d into master Mar 14, 2022
@myakhnis-shopify myakhnis-shopify deleted the add-dynamic-dispatch branch March 14, 2022 20:55
joshuamsager pushed a commit that referenced this pull request May 24, 2022
@myakhnis-shopify @joshuamsager
Add dynamic dispatch #18
32ad7ce
yknx4 pushed a commit that referenced this pull request May 30, 2022
@myakhnis-shopify @yknx4
Add dynamic dispatch #18
a330f4e
yknx4 pushed a commit that referenced this pull request May 31, 2022
@myakhnis-shopify @yknx4
Add dynamic dispatch #18
7905252
sbfaulkner pushed a commit that referenced this pull request Jun 16, 2022
@myakhnis-shopify @sbfaulkner
Add dynamic dispatch #18
5cd2780
sbfaulkner pushed a commit that referenced this pull request Jun 20, 2022
@myakhnis-shopify @sbfaulkner
Add dynamic dispatch #18
8de55f9
sbfaulkner pushed a commit that referenced this pull request Jun 25, 2022
@myakhnis-shopify @sbfaulkner
Add dynamic dispatch #18
0525d36
sbfaulkner pushed a commit that referenced this pull request Jun 27, 2022
@myakhnis-shopify @sbfaulkner
Add dynamic dispatch #18
81c2bc5
yknx4 pushed a commit that referenced this pull request Jul 13, 2022
@myakhnis-shopify @yknx4
Add dynamic dispatch #18
4b65bf2
yknx4 pushed a commit that referenced this pull request Jul 13, 2022
@myakhnis-shopify @yknx4
Add dynamic dispatch #18
e42ae63
sbfaulkner pushed a commit that referenced this pull request Nov 30, 2022
@myakhnis-shopify @sbfaulkner
Add dynamic dispatch #18
17809a3
uzo pushed a commit that referenced this pull request Dec 6, 2022
@myakhnis-shopify @uzo
Add dynamic dispatch #18
6d2ef34
@sbfaulkner sbfaulkner mentioned this pull request Jan 13, 2023
Merged
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GustavoCaso GustavoCaso GustavoCaso approved these changes

@davars davars Awaiting requested review from davars

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@myakhnis-shopify @GustavoCaso