-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
fwiw I think this is already upstream ... we're trying to figure out the best way to get back in sync or rebase with upstream since some of the most recent upstream changes have made rebasing more difficult than the last time(s) |
Yeah, I based my change partially off of theirs. But it looks like they refactored some of |
@myakhnis-shopify |
as per slack DM...
for reference the list of PRs that are included in the local branch...
most (if not all) of these likely become unneeded once Workers for Platforms is adopted My suggestion is to disconnect the fork and rename this repo for oxygen-specific "legacy" usage, so that if/when we need to fork the official master again we can. |
I chatted with the team, and we agree it's reasonable. That being said, this change will likely still be merged, and I'll file a separate ticket for the rename. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked against upstream looks good.
Description
https://github.com/cloudflare/cloudflare-go/pull/1160
(but adapted to work with older APIs)Has your change been tested?
Tested internally
Types of changes
What sort of change does your code introduce/modify?
Checklist: