Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rich text] List element tags aren't stripped out for the Rich Text Section's Heading Block #2170

Closed
kjellr opened this issue Dec 13, 2022 · 1 comment
Labels
Category: Bug Something isn't working

Comments

@kjellr
Copy link
Contributor

kjellr commented Dec 13, 2022

Describe the current behavior

#1635 implemented a rich text control for the the Rich Text section's Heading block, and set it up to have its <p> tags replaced with <span> tags when it's rendered. The RTE recently added inline list functionality, which is not stripped out. This leads to a weird visual bug where we have giant large, misaligned bullets in the heading. (Related #2155)

Describe the expected behavior

The intent of this field is to have it behave like a single-line richtext field, so we should strip out the bullets for now.

In the longterm, this richtext field should eventually be replaced with a inline_richtext to prevent these sorts of issues in the future, but that comes with some compounding issues, so I'd recommend we just fix this specific bug for now.

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 7.0.1
  • Chrome Version 108.0.5359.98
  • macOS Version 13.0.1

Possible solution

Strip out ul and li tags.

Additional context/screenshots

Screenshot 2022-12-13 at 2 20 45 PM

@kjellr
Copy link
Contributor Author

kjellr commented Mar 15, 2023

Closing because #2326 fixes this. 👍

@kjellr kjellr closed this as completed Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant