Remove/Replace unordered list tags in the Rich Text Section's Heading Block #2171
Conversation
| @@ -26,7 +26,7 @@ | |||
| {%- case block.type -%} | |||
| {%- when 'heading' -%} | |||
| <h2 class="rich-text__heading rte {{ block.settings.heading_size }}" {{ block.shopify_attributes }}> | |||
| {{ block.settings.heading | replace: 'p>', 'span>' }} | |||
| {{ block.settings.heading | replace: 'p>', 'span>' | replace: 'li>', 'span>' | remove: '<ul>' | remove: '</ul>' }} | |||
There was a problem hiding this comment.
I'd say I'm not for this change. It's visually going to impact a merchant stores and I think it's more a patch of something we should actually fix.
Screenshot
We should change the from richtext to inline-text and either have it part of the next update which can impact merchants manually upgrading to it or we might have a fix in the background that fixes that for them.
There was a problem hiding this comment.
I totally agree that we should migrate this to inline_richtext. My reasoning for patching this fix now is:
- In general, it definitely looks like a bug. I don't expect this is what any merchant wants this to look like. Unordered lists are a brand new feature, and this makes the rollout seem unconsidered and unpolished.
- Even if this were an appearance that the merchant wants, I don't think it makes sense to allow merchants to start using lists here considering our ultimate plans are to switch this to an inline field.
Given that we don't have a definite solution to the richtext > inline_richtext migration issue yet, I think it makes sense to just push this as a really minor temporary fix.
|
Closing because #2326 makes this unnecessary. 👍 |
PR Summary:
Why are these changes introduced?
Fixes #2170
What approach did you take?
The intent of this field is to have it behave like a single-line richtext field, so this PR should strips out the bullets for now.
Before
After
Other considerations
(In the longterm, this
richtextfield should eventually be replaced with ainline_richtextto prevent these sorts of issues in the future, but for now this specific bug should be fixed.)Visual impact on existing themes
If they have broken-looking bullets in this heading, the broken-looking bullets will disappear.
Testing steps/scenarios
<span>upon render.Checklist