[Rich text] Change rich text section heading type #2326
Conversation
…moved rte styling into base.css
| product: product, | ||
| product_form_id: product_form_id, | ||
| section_id: section.id | ||
| -%} |
There was a problem hiding this comment.
There are a bunch of little reformatting additions like these that make it harder to review. None of it appears to actually change anything though.
There was a problem hiding this comment.
Yeah 😞 I will add a note in the PR description to mention this. We're trying to default to use our own prettier extension and I guess some stuff wasn't formatted in some files.
|
Thanks for following through on this. It's working well in my testing! It's nice to eliminate all the extra I left one comment inline, and have just a single followup question here:
When this happens do we/can we do anything to alert the user? Or can we at least warn them up front before upgrade? |
We will have to make sure the next release or the release it's part of is one where we don't force push the update/changes. Manual update means there are visual/breaking changes, so historically it's always meant having to double check your theme to make sure everything looks ok. So far we don't have a lot of ways to warn the merchants but through our release notes. |
|
Makes sense. Out of curiosity, do we have any idea how many merchants use meta objects inside those fields today? I wonder how many folks this might effect. |
* shopify/main: Improve image sizes in the multicolumn section (Shopify#2349) Fix the Page section's width. (Shopify#2364) Update 12 translation files (Shopify#2366) Removing "my" from cart popup notification (Shopify#2353) [Cart.js] Fix fetch url so it's not hard coded (Shopify#2357) (Shopify#2365) Update 1 translation file (Shopify#2352) Default Follow on Shop to on [Header] Add localization selectors (Shopify#2258) Remove async CSS pattern where it may introduce layout shifts (Shopify#2270) Change rich text section heading to be of type inline_richtext, also moved rte styling into base.css (Shopify#2326) Add drawer menu desktop (Shopify#2195) Make header image preload and proper width (Shopify#2307)
…moved rte styling into base.css (Shopify#2326)
PR Summary:
Change the richtext section heading block type to be an
inline_richtexttype instead ofrichtext.Move the
component-rte.cssstyling intobase.csssince its loaded on every page.Fixes #2209
Why are these changes introduced?
Continue the work done by @kjellr so that most headings in our theme are using this type.
Visual impact on existing themes
There is a visual change expected for merchants that used the richtext specific features in their heading but we're planning to do some backend work to limit the loss of their content when upgrading to the next theme version.
Though some content can still be lost like metafields
Testing steps/scenarios
inline_richtextallowing you to only do bold, italic and links.Demo links
Checklist