Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/Replace unordered list tags in the Rich Text Section's Heading Block #2171

Closed
wants to merge 2 commits into from
Closed

Remove/Replace unordered list tags in the Rich Text Section's Heading Block #2171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4b1b5b
Remove/Replace unordered list tags.
kjellr Dec 13, 2022
f92bc70
Ensure li items are each in their own span tags.
kjellr Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sections/rich-text.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
{%- case block.type -%}
{%- when 'heading' -%}
<h2 class="rich-text__heading rte {{ block.settings.heading_size }}" {{ block.shopify_attributes }}>
{{ block.settings.heading | replace: 'p>', 'span>' }}
{{ block.settings.heading | replace: 'p>', 'span>' | replace: 'li>', 'span>' | remove: '<ul>' | remove: '</ul>' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say I'm not for this change. It's visually going to impact a merchant stores and I think it's more a patch of something we should actually fix.

Screenshot

We should change the from richtext to inline-text and either have it part of the next update which can impact merchants manually upgrading to it or we might have a fix in the background that fixes that for them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree that we should migrate this to inline_richtext. My reasoning for patching this fix now is:

  • In general, it definitely looks like a bug. I don't expect this is what any merchant wants this to look like. Unordered lists are a brand new feature, and this makes the rollout seem unconsidered and unpolished.
  • Even if this were an appearance that the merchant wants, I don't think it makes sense to allow merchants to start using lists here considering our ultimate plans are to switch this to an inline field.

Given that we don't have a definite solution to the richtext > inline_richtext migration issue yet, I think it makes sense to just push this as a really minor temporary fix.

</h2>
{%- when 'caption' -%}
<p class="rich-text__caption {{ block.settings.text_style }} {{ block.settings.text_style }}--{{ block.settings.text_size }}" {{ block.shopify_attributes }}>
Expand Down