This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
adds `react-no-render-methods’ rule #134
Merged
+169
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartogram
force-pushed
the
react-no-render-methods
branch
from
5d6ad90
to
288922e
Compare
cartogram
force-pushed
the
react-no-render-methods
branch
2 times, most recently
from
673bfa2
to
4f691ce
Compare
lemonmade
reviewed
Aug 3, 2018
lib/rules/react-no-render-methods.js
Outdated
| @@ -0,0 +1,46 @@ | |||
| const Components = require('eslint-plugin-react/lib/util/Components'); | |||
There was a problem hiding this comment.
Name is a little misleading since there is still a render method 🙃
There was a problem hiding this comment.
what about react-no-multiple-render-methods?
lib/rules/react-no-render-methods.js
Outdated
|
|
||
| context.report({ | ||
| node, | ||
| message: `No renderX methods. '{{name}}' should be a seperate component.`, |
There was a problem hiding this comment.
Message is a little too direct
cartogram
force-pushed
the
react-no-render-methods
branch
3 times, most recently
from
f94c6c5
to
952d305
Compare
cartogram
force-pushed
the
react-no-render-methods
branch
from
952d305
to
2bd5e5a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127
Looking for feedback on the name and general approach.