This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Don't report nested arrow functions in jest/no-if
#331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #311
This PR changes jest/no-if so that it reports on if statements that are nested in arrow functions (all of which would be nested in a test CallExpression). This fix was done in 2 steps:
The rest of the logic remained the same. We check to see if the last item pushed was true/false, and report if it is.
In other words, "if we are an if statement and we are just inside an arrow function and that arrow function that we are just inside is part of an it/test/etc... function, then we report it".
I implemented this by adding a new jest utility for checking if an ArrowFunction is part of an it/test/etc... function.
cc @BPScott