Don't report nested arrow functions in jest/no-if

CHANGELOG.md

@@ -3,10 +3,12 @@
 ## Unreleased
 
 ### Changed
-
 - [Major] Updated to eslint v6, enabled `no-console` and enabled `no-async-promise-executor` ([330](https://github.com/Shopify/eslint-plugin-shopify/pull/330))
 - Enabled `typescript/interface-name-prefix` to prevent `I` prefixes in TypeScript interface names
 
+### Fixed
+- [Patch] Fix `jest/no-if` from falsely reporting if statements inside of arrow functions ([331](https://github.com/Shopify/eslint-plugin-shopify/pull/331))
+
 ## [29.0.2] - 2019-06-18
 
 ### Changed

lib/rules/jest/no-if.js

@@ -1,5 +1,5 @@
 const {docsUrl} = require('../../utilities');
-const {isTestDefinition} = require('../../utilities/jest');
+const {isTestDefinition, isTestArrowFunction} = require('../../utilities/jest');
 
 module.exports = {
   meta: {
@@ -56,11 +56,29 @@ module.exports = {
       CallExpression(node) {
         stack.push(isTestDefinition(node));
       },
+      FunctionExpression() {
+        stack.push(false);
+      },
+      FunctionDeclaration() {
+        stack.push(false);
+      },
+      ArrowFunctionExpression(node) {
+        stack.push(isTestArrowFunction(node));
+      },
       IfStatement: validate,
       ConditionalExpression: validate,
       'CallExpression:exit': function() {
         stack.pop();
       },
+      'FunctionExpression:exit': function() {
+        stack.pop();
+      },
+      'FunctionDeclaration:exit': function() {
+        stack.pop();
+      },
+      'ArrowFunctionExpression:exit': function() {
+        stack.pop();
+      },
     };
   },
 };

lib/utilities/jest.js

@@ -33,8 +33,17 @@ function isTestDefinition(node) {
   );
 }
 
+function isTestArrowFunction(node) {
+  return (
+    node.type === 'ArrowFunctionExpression' &&
+    node.parent.type === 'CallExpression' &&
+    TEST_DEFINITION_NAMES.includes(getTestMethodName(node.parent))
+  );
+}
+
 module.exports = {
   TEST_FUNCTION_NAMES,
   getTestMethodName,
   isTestDefinition,
+  isTestArrowFunction,
 };

tests/lib/rules/jest/no-if.js

@@ -126,6 +126,49 @@ ruleTester.run('no-if', rule, {
       });
       `,
     },
+    {
+      code: `it('foo', () => {
+        const foo = bar => {
+          return foo ? bar : null;
+        };
+      });`,
+    },
+    {
+      code: `it('foo', () => {
+        const foo = function(bar) {
+          return foo ? bar : null;
+        };
+      });`,
+    },
+    {
+      code: `it('foo', () => {
+        const foo = function(bar) {
+          if (bar) {
+            return 1;
+          } else {
+            return 2;
+          }
+        };
+      });`,
+    },
+    {
+      code: `it('foo', () => {
+        function foo(bar) {
+          return foo ? bar : null;
+        };
+      });`,
+    },
+    {
+      code: `it('foo', () => {
+        function foo(bar) {
+          if (bar) {
+            return 1;
+          } else {
+            return 2;
+          }
+        };
+      });`,
+    },
   ],
   invalid: [
     {