Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

lines-around-directive deprecated since ESLint 4.0.0 #44

Merged
merged 2 commits into from
Oct 23, 2017

Conversation

ismail-syed
Copy link
Contributor

@ismail-syed ismail-syed commented Sep 27, 2017

lines-around-directive has been deprecated as per their rule docs. I didn't/don't see it explicitly listed in their changelog. It's been replaced with replaced by the padding-line-between-statements rule, which we have disabled.

@GoodForOneFare
Copy link
Member

This was replaced by padding-line-between-statements. Can you try adding a directive config that mimics the deprecated rule.

The docs suggest this:

[{ blankLine: "always", prev: "directive", next: "*" }, { blankLine: "any", prev: "directive", next: "directive" }]

@ismail-syed
Copy link
Contributor Author

@GoodForOneFare another 👀 , please.

Copy link
Member

@GoodForOneFare GoodForOneFare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tried this out in admin (with an eslint version bump) and it works as expected.

@ismail-syed ismail-syed merged commit 8bbe27d into master Oct 23, 2017
@kaelig kaelig deleted the deprecated-lines-around-directive branch January 12, 2018 02:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants