Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

lines-around-directive deprecated since ESLint 4.0.0 #44

Merged
merged 2 commits into from
Oct 23, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@

### Changed
* `space-before-function-paren` now uses `asyncArrow` option (eg. `async () => {}`)

* `lines-around-directive` was deprecated in ESLint `v4.0.0`.
* Enable `padding-line-between-statements` for directives
## [17.1.0] - 2017-09-19

### Added
Expand Down
8 changes: 5 additions & 3 deletions lib/config/rules/stylistic-issues.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ module.exports = {
'linebreak-style': 'off',
// Enforces empty lines around comments
'lines-around-comment': ['warn', {beforeBlockComment: true}],
// Require or disallow newlines around directives
'lines-around-directive': ['warn', 'always'],
// Enforce position of line comments
'line-comment-position': ['warn', {position: 'above'}],
// Enforce a maximum file length
Expand Down Expand Up @@ -136,7 +134,11 @@ module.exports = {
// Enforce padding within blocks
'padded-blocks': 'off',
// require or disallow padding lines between statements
'padding-line-between-statements': 'off',
'padding-line-between-statements': [
'error',
{blankLine: 'always', prev: 'directive', next: '*'},
{blankLine: 'any', prev: 'directive', next: 'directive'},
],
// Require quotes around object literal property names
'quote-props': ['warn', 'as-needed'],
// Specify whether backticks, double or single quotes should be used
Expand Down