This repository has been archived by the owner on Apr 27, 2021. It is now read-only.
forked from kubernetes/ingress-nginx
-
Notifications
You must be signed in to change notification settings - Fork 25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following annotations will be added: - enable-modsecurity - enable-owasp-core-rules - modsecurity-transaction-id Fixes kubernetes#3167
Customize ModSecurity to be used in Locations
Signed-off-by: mooncake <xcoder@tenxcloud.com>
Fix typos: reqrite -> rewrite
Update annotations.md. Remove Duplication.
Modify the wrong function name
Add e2e test for round robin load balancing
Signed-off-by: mooncake <xcoder@tenxcloud.com>
Fix some documents issues
Update nginx and e2e image
Restructure load balance e2e tests and update round robin test
Prevent X-Forwarded-Proto forward during external auth subrequest
fix logging calls
bugfix: set canary attributes when initializing balancer
… it for client_max_body_size
Convert isValidClientBodyBufferSize to something more generic
Add Snippet for ModSecurity
Set proxy_host variable to avoid using default value from proxy_pass
Revert removal of support for TCP and UDP services
Add annotation for session affinity path
Only set cookies on paths that enable session affinity
…_def bugfix: do not merge catch-all canary backends with itself
Increase log level when there is an invalid size value
Match buffer
Use struct to pack Ingress and its annotations
Remove initial log error during reconfiguration
Monitor fixes
And I don't know why it's showing the commits that are already in our master branch, diff is correct though. |
wayt
approved these changes
Nov 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Noticable changes:
and more visibly kubernetes#3437 - this is expected to fix unexpected
nginx: configuration file /tmp/nginx-cfg216910757 test failed
errors (there will still potentially by legit errors caused by misconfigured ingresses).@Shopify/edgescale