Skip to content

Commit

Permalink
Merge pull request #425 from Shopify/update-implemeting-session-stora…
Browse files Browse the repository at this point in the history
…ge-link

Hardcode links to the implementing session storage so that the link work on npm.js
  • Loading branch information
byrichardpowell authored Sep 1, 2023
2 parents 404b10e + 28ba663 commit 1a1e122
Show file tree
Hide file tree
Showing 10 changed files with 11 additions and 9 deletions.
2 changes: 2 additions & 0 deletions .changeset/thick-houses-protect.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
2 changes: 1 addition & 1 deletion packages/shopify-app-session-storage-dynamodb/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ const shopify = shopifyApp({
});
```

If you prefer to use your own implementation of a session storage mechanism that uses the `SessionStorage` interface, see the [implementing session storage guide](../shopify-app-session-storage/implementing-session-storage.md).
If you prefer to use your own implementation of a session storage mechanism that uses the `SessionStorage` interface, see the [implementing session storage guide](https://github.com/Shopify/shopify-app-js/blob/main/packages/shopify-app-session-storage/implementing-session-storage.md).
2 changes: 1 addition & 1 deletion packages/shopify-app-session-storage-kv/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ const shopify = shopifyApp({
});
```

If you prefer to use your own implementation of a session storage mechanism that uses the `SessionStorage` interface, see the [implementing session storage guide](../shopify-app-session-storage/implementing-session-storage.md).
If you prefer to use your own implementation of a session storage mechanism that uses the `SessionStorage` interface, see the [implementing session storage guide](https://github.com/Shopify/shopify-app-js/blob/main/packages/shopify-app-session-storage/implementing-session-storage.md).
2 changes: 1 addition & 1 deletion packages/shopify-app-session-storage-memory/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ const shopify = shopifyApp({
> It will delete all sessions if the app process gets restarted or redeployed, and is not meant for production use.
> For persistent storage, use one of the other options (see relevant section above for instructions).
If you prefer to use your own implementation of a session storage mechanism that is compatible with the `@shopify/shopify-app-express` package, see the [implementing session storage guide](../shopify-app-session-storage/implementing-session-storage.md).
If you prefer to use your own implementation of a session storage mechanism that is compatible with the `@shopify/shopify-app-express` package, see the [implementing session storage guide](https://github.com/Shopify/shopify-app-js/blob/main/packages/shopify-app-session-storage/implementing-session-storage.md).
2 changes: 1 addition & 1 deletion packages/shopify-app-session-storage-mongodb/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ const shopify = shopifyApp({
});
```

If you prefer to use your own implementation of a session storage mechanism that is compatible with the `@shopify/shopify-app-express` package, see the [implementing session storage guide](../shopify-app-session-storage/implementing-session-storage.md).
If you prefer to use your own implementation of a session storage mechanism that is compatible with the `@shopify/shopify-app-express` package, see the [implementing session storage guide](https://github.com/Shopify/shopify-app-js/blob/main/packages/shopify-app-session-storage/implementing-session-storage.md).
2 changes: 1 addition & 1 deletion packages/shopify-app-session-storage-mysql/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ const shopify = shopifyApp({
});
```

If you prefer to use your own implementation of a session storage mechanism that is compatible with the `@shopify/shopify-app-express` package, see the [implementing session storage guide](../shopify-app-session-storage/implementing-session-storage.md).
If you prefer to use your own implementation of a session storage mechanism that is compatible with the `@shopify/shopify-app-express` package, see the [implementing session storage guide](https://github.com/Shopify/shopify-app-js/blob/main/packages/shopify-app-session-storage/implementing-session-storage.md).
2 changes: 1 addition & 1 deletion packages/shopify-app-session-storage-postgresql/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ const shopify = shopifyApp({
});
```

If you prefer to use your own implementation of a session storage mechanism that is compatible with the `@shopify/shopify-app-express` package, see the [implementing session storage guide](../shopify-app-session-storage/implementing-session-storage.md).
If you prefer to use your own implementation of a session storage mechanism that is compatible with the `@shopify/shopify-app-express` package, see the [implementing session storage guide](https://github.com/Shopify/shopify-app-js/blob/main/packages/shopify-app-session-storage/implementing-session-storage.md).
2 changes: 1 addition & 1 deletion packages/shopify-app-session-storage-prisma/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const shopify = shopifyApp({

> **Note**: If you use [SQLite](https://sqlite.com) with Prisma note that sqlite is a local, file-based SQL database. It persists all tables to a single file on your local disk. As such, it’s simple to set up and is a great choice for getting started with Shopify App development. However, it won’t work when your app getting scaled across multiple instances because they would each create their own database.
If you prefer to use your own implementation of a session storage mechanism that is compatible with the `@shopify/shopify-app-express` package, see the [implementing session storage guide](../shopify-app-session-storage/implementing-session-storage.md).
If you prefer to use your own implementation of a session storage mechanism that is compatible with the `@shopify/shopify-app-express` package, see the [implementing session storage guide](https://github.com/Shopify/shopify-app-js/blob/main/packages/shopify-app-session-storage/implementing-session-storage.md).

## Troubleshooting

Expand Down
2 changes: 1 addition & 1 deletion packages/shopify-app-session-storage-redis/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ const shopify = shopifyApp({
});
```

If you prefer to use your own implementation of a session storage mechanism that is compatible with the `@shopify/shopify-app-express` package, see the [implementing session storage guide](../shopify-app-session-storage/implementing-session-storage.md).
If you prefer to use your own implementation of a session storage mechanism that is compatible with the `@shopify/shopify-app-express` package, see the [implementing session storage guide](https://github.com/Shopify/shopify-app-js/blob/main/packages/shopify-app-session-storage/implementing-session-storage.md).
2 changes: 1 addition & 1 deletion packages/shopify-app-session-storage-sqlite/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ const shopify = shopifyApp({

> **Note**: [SQLite](https://sqlite.com) is a local, file-based SQL database. It persists all tables to a single file on your local disk. As such, it’s simple to set up and is a great choice for getting started with Shopify App development. However, it won’t work when your app getting scaled across multiple instances because they would each create their own database.
If you prefer to use your own implementation of a session storage mechanism that is compatible with the `@shopify/shopify-app-express` package, see the [implementing session storage guide](../shopify-app-session-storage/implementing-session-storage.md).
If you prefer to use your own implementation of a session storage mechanism that is compatible with the `@shopify/shopify-app-express` package, see the [implementing session storage guide](https://github.com/Shopify/shopify-app-js/blob/main/packages/shopify-app-session-storage/implementing-session-storage.md).

0 comments on commit 1a1e122

Please sign in to comment.