Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcode links to the implementing session storage so that the link work on npm.js #425

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Hardcode links to the implementing session storage so that the link work on npm.js #425

merged 2 commits into from
Sep 1, 2023

Conversation

byrichardpowell
Copy link
Contributor

WHY are these changes introduced?

Fixes: #417

WHAT is this pull request doing?

Hardcodes the link

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used yarn changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@byrichardpowell byrichardpowell requested a review from a team as a code owner August 31, 2023 19:07
@byrichardpowell byrichardpowell merged commit 1a1e122 into main Sep 1, 2023
13 checks passed
@byrichardpowell byrichardpowell deleted the update-implemeting-session-storage-link branch September 1, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulomarg paulomarg paulomarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link on npmjs readme 404s
2 participants
@byrichardpowell @paulomarg