Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API version and shopify-app-remix version #863

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

andy-liuu
Copy link
Contributor

@andy-liuu andy-liuu commented Oct 2, 2024

WHY are these changes introduced?

  • maintenance after shopify-app-remix release to 3.3.2

WHAT is this pull request doing?

  • version changes

Test this PR

shopify app init --template=https://github.com/Shopify/shopify-app-template-remix#<your-branch-name>

Checklist

  • I have made changes to the README.md file and other related documentation, if applicable
  • I have added an entry to CHANGELOG.md
  • I'm aware I need to create a new release when this PR is merged

@andy-liuu andy-liuu requested a review from a team as a code owner October 2, 2024 20:27
@andy-liuu andy-liuu merged commit 8b74e29 into main Oct 2, 2024
5 checks passed
@andy-liuu andy-liuu deleted the andy-liuu/update-versions branch October 2, 2024 20:34
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
* api version and remix package version

* changelog

* update pr link

* Update CHANGELOG.md
andy-liuu added a commit that referenced this pull request Oct 2, 2024
* Update API version and shopify-app-remix version (#863)

* api version and remix package version

* changelog

* update pr link

* Update CHANGELOG.md

* Convert template to Javascript

---------

Co-authored-by: Andy Liu <59021924+andy-liuu@users.noreply.github.com>
Co-authored-by: GitHub <noreply@github.com>
@andy-liuu andy-liuu self-assigned this Nov 21, 2024
@Brahim-Benzarti
Copy link

Shouldn't the restResources also get updated to the 2024-10 version ?

At shopify.server.ts, line 8:
import { restResources } from "@shopify/shopify-api/rest/admin/2024-07";
Should be:
import { restResources } from "@shopify/shopify-api/rest/admin/2024-10";

@andy-liuu
Copy link
Contributor Author

@Brahim-Benzarti

Thanks for flagging! The team has made this change in #888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants