Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rest resource version to 2024-10 #888

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

andy-liuu
Copy link
Contributor

@andy-liuu andy-liuu commented Nov 26, 2024

WHY are these changes introduced?

WHAT is this pull request doing?

Test this PR

shopify app init --template=https://github.com/Shopify/shopify-app-template-remix#andy-liuu/update-rest-resources-2024-10

Checklist

  • I have made changes to the README.md file and other related documentation, if applicable
  • I have added an entry to CHANGELOG.md
  • I'm aware I need to create a new release when this PR is merged

@andy-liuu andy-liuu marked this pull request as ready for review November 26, 2024 15:19
@andy-liuu andy-liuu requested a review from a team as a code owner November 26, 2024 15:19
Copy link
Contributor

@lizkenyon lizkenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update the webhook version in the shopify.app.toml

Copy link
Contributor

@lizkenyon lizkenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyty!

@andy-liuu andy-liuu merged commit 39f9e1d into main Nov 26, 2024
5 checks passed
@andy-liuu andy-liuu deleted the andy-liuu/update-rest-resources-2024-10 branch November 26, 2024 16:24
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
* update rest resources version

* changelog

* webhook api version to 2024-10
@andy-liuu andy-liuu self-assigned this Nov 26, 2024
andy-liuu added a commit that referenced this pull request Nov 26, 2024
* Update rest resource version to 2024-10 (#888)

* update rest resources version

* changelog

* webhook api version to 2024-10

* Convert template to Javascript

---------

Co-authored-by: Andy Liu <59021924+andy-liuu@users.noreply.github.com>
Co-authored-by: GitHub <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants