Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toxiproxy v2.1.5 can't be used as a client module without /v2 suffix #310

Closed
dnwe opened this issue Sep 13, 2021 · 0 comments · Fixed by #311
Closed

toxiproxy v2.1.5 can't be used as a client module without /v2 suffix #310

dnwe opened this issue Sep 13, 2021 · 0 comments · Fixed by #311

Comments

@dnwe
Copy link
Contributor

dnwe commented Sep 13, 2021

Since #253 added a go.mod for toxiproxy, the v2.x.x release from v2.1.5 can no longer be referred to as an +incompatible module dependency and is required to have a /v2 suffix on the module path.

server response: not found: github.com/Shopify/toxiproxy@v2.1.5+incompatible: 
  invalid version: +incompatible suffix not allowed: 
    module contains a go.mod file, so semantic import versioning is required

(see Go Modules have a v2+ Problem for further discussion)
dnwe added a commit to dnwe/toxiproxy that referenced this issue Sep 13, 2021
@dnwe
chore: add /v2 suffix to module import path
165feee 
Since Shopify#253 added a `go.mod` for
toxiproxy, the v2.x.x release from v2.1.5 can no longer be referred to
as an `+incompatible` module dependency and is required to have a `/v2`
suffix on the module path.

```
server response: not found: github.com/Shopify/toxiproxy@v2.1.5+incompatible:
  invalid version: +incompatible suffix not allowed:
    module contains a go.mod file, so semantic import versioning is required
```
(see [Go Modules have a v2+ Problem](https://donatstudios.com/Go-v2-Modules) for further discussion)

Fixes Shopify#310
@dnwe dnwe mentioned this issue Sep 13, 2021
Merged
@miry miry closed this as completed in #311 Sep 14, 2021
miry pushed a commit that referenced this issue Sep 14, 2021
@dnwe @miry
chore: add /v2 suffix to module import path
9447d38 
Since #253 added a `go.mod` for
toxiproxy, the v2.x.x release from v2.1.5 can no longer be referred to
as an `+incompatible` module dependency and is required to have a `/v2`
suffix on the module path.

```
server response: not found: github.com/Shopify/toxiproxy@v2.1.5+incompatible:
  invalid version: +incompatible suffix not allowed:
    module contains a go.mod file, so semantic import versioning is required
```
(see [Go Modules have a v2+ Problem](https://donatstudios.com/Go-v2-Modules) for further discussion)

Fixes #310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add /v2 suffix to module import path dnwe/toxiproxy
1 participant
@dnwe