Move to go modules #253
Merged
Move to go modules #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epk
requested review from
thegedge
and removed request for
sirupsen and
shivnagarajan
|
Everything looks 👍, but I don't do a lot of work here so let's find someone who does and see if they're happy moving to modules. |
shivnagarajan
approved these changes
Jun 19, 2019
dnwe
added a commit
to dnwe/toxiproxy
that referenced
this pull request
Sep 13, 2021
Since Shopify#253 added a `go.mod` for toxiproxy, the v2.x.x release from v2.1.5 can no longer be referred to as an `+incompatible` module dependency and is required to have a `/v2` suffix on the module path. ``` server response: not found: github.com/Shopify/toxiproxy@v2.1.5+incompatible: invalid version: +incompatible suffix not allowed: module contains a go.mod file, so semantic import versioning is required ``` (see [Go Modules have a v2+ Problem](https://donatstudios.com/Go-v2-Modules) for further discussion) Fixes Shopify#310
miry
pushed a commit
that referenced
this pull request
Sep 14, 2021
Since #253 added a `go.mod` for toxiproxy, the v2.x.x release from v2.1.5 can no longer be referred to as an `+incompatible` module dependency and is required to have a `/v2` suffix on the module path. ``` server response: not found: github.com/Shopify/toxiproxy@v2.1.5+incompatible: invalid version: +incompatible suffix not allowed: module contains a go.mod file, so semantic import versioning is required ``` (see [Go Modules have a v2+ Problem](https://donatstudios.com/Go-v2-Modules) for further discussion) Fixes #310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Move to Go Modules from godeps