Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimum Ruby version #122

Merged
merged 2 commits into from
Sep 23, 2016
Merged

Add minimum Ruby version #122

merged 2 commits into from
Sep 23, 2016

Conversation

gmalette
Copy link
Contributor

@gmalette gmalette commented Aug 10, 2016 •
edited
Loading

This PR bumps the Ruby dependency of TG to Ruby 2.0. This is required for prepend.

It also addresses @phoet's comment.

gmalette
gmalette reviewed Aug 10, 2016
View reviewed changes
.travis.yml
- DISPLAY=':99.0' RAILS_VERSION='4.2.0'
- DISPLAY=':99.0' RAILS_VERSION='4.1.0'
- DISPLAY=':99.0' RAILS_VERSION='4.2.0'
- DISPLAY=':99.0' RAILS_VERSION='5.0.0'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the RAILS_VERSION does anything useful, unless I'm mistaking

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen shot 2016-08-10 at 10 09 05 am

This RAILS_VERSION tells travis which rails to test with

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's what we expect it to do, but I don't think that's what it does

image

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞 lol

@qq99
Copy link
Contributor

qq99 commented Aug 10, 2016

weird

Listening on 127.0.0.1:37716, CTRL+C to stop
Teaspoon running default suite at http://127.0.0.1:37716/teaspoon/default
rake aborted!
Errno::EINVAL: Invalid argument - bind(2) for "fe80::4001:aff:fef0:30" port 7055
/home/travis/.rvm/gems/ruby-2.2.2/gems/selenium-webdriver-2.53.4/lib/selenium/webdriver/common/port_prober.rb:47:in `initialize'

@qq99
Copy link
Contributor

qq99 commented Aug 10, 2016

Could be travis problems? your build/branch is not the only one failing

@gmalette gmalette mentioned this pull request Aug 11, 2016
Closed
@gmalette
Copy link
Contributor Author

ping for review

@qq99
Copy link
Contributor

qq99 commented Aug 11, 2016

cc @Shopify/tnt

@rafaelfranca
Copy link
Member

👍

@marutypes
Copy link
Contributor

The random fails were probably from the tests that used to be flaky. I don't see why we can't just ship this now :)

@gmalette
Copy link
Contributor Author

gmalette commented Sep 7, 2016

@Shopify/tnt reping

@marutypes
Copy link
Contributor

@Shopify/tnt Unless anyone has any great hatred for this I'll merge it today.

@gmalette
Copy link
Contributor Author

@TheMallen they haven't responded at all, I think you're good

@marutypes
Copy link
Contributor

I just rebased it on master and I'll let CI run, then we'll :shipit:

@marutypes marutypes merged commit 5de6be1 into master Sep 23, 2016
@marutypes marutypes deleted the minimum-ruby-version branch September 23, 2016 15:08
GoodForOneFare added a commit that referenced this pull request Oct 4, 2016
@GoodForOneFare
Version bump to 0.4.3 (#164)
a5453e6 
Changes
=======
* #122 - Specify minimum Ruby version
* #145 - Defend against nulls in full page navigate
* #144 - Refactor process doc; add new error
* #163 - Turbolinks accepts a document and runs tests inside an iframe
@casperisfine casperisfine temporarily deployed to rubygems September 1, 2020 12:29 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gmalette @qq99 @rafaelfranca @marutypes @casperisfine