-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimum Ruby version #122
Conversation
- DISPLAY=':99.0' RAILS_VERSION='4.2.0' | ||
- DISPLAY=':99.0' RAILS_VERSION='4.1.0' | ||
- DISPLAY=':99.0' RAILS_VERSION='4.2.0' | ||
- DISPLAY=':99.0' RAILS_VERSION='5.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the RAILS_VERSION
does anything useful, unless I'm mistaking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😞 lol
weird
|
Could be travis problems? your build/branch is not the only one failing |
46c634a
to
4e7dad9
Compare
ping for review |
cc @Shopify/tnt |
👍 |
The random fails were probably from the tests that used to be flaky. I don't see why we can't just ship this now :) |
@Shopify/tnt reping |
@Shopify/tnt Unless anyone has any great hatred for this I'll merge it today. |
@TheMallen they haven't responded at all, I think you're good |
4e7dad9
to
a550d77
Compare
I just rebased it on master and I'll let CI run, then we'll |
This PR bumps the Ruby dependency of TG to Ruby 2.0. This is required for
prepend
.It also addresses @phoet's comment.