turbolinks accepts a document, run tests inside an iframe #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice :D |
| afterEach -> | ||
| Turbolinks.document(testDocument) | ||
|
|
||
| it 'assigning a document', -> |
There was a problem hiding this comment.
Rename to state some kind of behaviour, or cause and effect. Or just delete.
|
I can run browser tests! 😃 Excellent stuff 👍 |
marutypes
force-pushed
the
enhancement/turbolinks#document
branch
from
1f59b1c
to
34a7bb6
Compare
…an iframe group iframe setup into function remove silly test, fix results
marutypes
force-pushed
the
enhancement/turbolinks#document
branch
from
34a7bb6
to
9eee511
Compare
|
@qq99 You think this is good to 🚢 ? |
qq99
reviewed
Oct 3, 2016
| @@ -42,7 +43,7 @@ requestMethodIsSafe = | |||
| browserSupportsTurbolinks = browserSupportsPushState and requestMethodIsSafe | |||
|
|
|||
| browserSupportsCustomEvents = | |||
| document.addEventListener and document.createEvent | |||
| activeDocument.addEventListener and activeDocument.createEvent | |||
There was a problem hiding this comment.
this could probably just be document right?
There was a problem hiding this comment.
well you actually want to know it about the document you're operating on, but it usually shouldn't matter
qq99
approved these changes
Oct 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have a browser runner again!
(closes #138)
This PR makes two primary changes.
Turbolinks.documentallows you to set a document for turbolinks to operate on.How
We had to move the way we defined ASSET_FIXTURES due to some weirdness in teaspoon config, and change all uses of
documentto reference a variable in module scope to facilitate this change. We also had to make some minor changes in how we initialize tests.Why
Development velocity is better when we can actually use the browser test runner. Everything else is gravy.
Follow up:
We should change
remote_testto do this as well, since it's currently suffering from the same problemturbolinks_testhad.Reviewers
@qq99
@GoodForOneFare
@edward
CC @Shopify/tnt