Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues #152

Closed
wants to merge 1 commit into from
Closed

Fix build issues #152

wants to merge 1 commit into from

Conversation

shanth96
Copy link

This PR is a followup to #149 in order to fix build-specific issues.

Essentially, vttestserver builds were failing with the error:

#10 93.94 The following packages have unmet dependencies:
#10 94.01  percona-xtrabackup-80 : Depends: libprocps7 (>= 2:3.3.15-1) but it is not installable
#10 94.02 E: Unable to correct problems, you have held broken packages.

This is because they updated vttestserver Dockerfile to use bullseye image in vitessio#13921 but try to install packages for buster inside install_dependencies.sh.

This PR adds another "flavor" to the install_dependencies.sh script to use bullseye repo and install the correct packages that would work with bullseye.

@brendar
Copy link

brendar commented Mar 26, 2024

  1. Is this impacting upstream as well?
  2. Would it make sense to update the package references rather than introduce a new "flavor" which generally refers to the mysql version/distribution and not the OS?

@pawandubey
Copy link

  1. Is this impacting upstream as well?

This is fixed in upstream version 18 onwards as that is when they changed the repositories to bullseye for everything except mysql 5.7, but does impact versions 16 and 17 as far as we can tell.

  1. Would it make sense to update the package references rather than introduce a new "flavor" which generally refers to the mysql version/distribution and not the OS?

We discussed this with Austen earlier today and decided to backport the upstream changes that fix the issue in later releases into our releases for 16 and 17. Shanth can expand more. This is the main PR to bring in I think: vitessio#13664

@shanth96
Copy link
Author

We discussed this with Austen earlier today and decided to backport the upstream changes that fix the issue in later releases into our releases for 16 and 17. Shanth can expand more. This is the main PR to bring in I think: vitessio#13664

Yes, we're gonna try to bring in the upstream PR and if it fixes our issue, we'll cherry pick that onto v16.

The original intention of this PR was as a stop-gap solution till we upgraded to v18. Since we will be upgrading things consecutively, we thought it might be okay to fix it like this temporarily without upstreaming a proper fix.

@shanth96 shanth96 mentioned this pull request Apr 3, 2024
@shanth96
Copy link
Author

shanth96 commented Apr 3, 2024

Closing in favor of #153

@shanth96 shanth96 closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants