Fix build issues #153
Merged
Fix build issues #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pawandubey
approved these changes
Apr 3, 2024
shivnagarajan
approved these changes
Apr 3, 2024
shivnagarajan
pushed a commit
that referenced
this pull request
May 8, 2024
Fix build issues (cherry picked from commit 2815e0e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #152
I tried cherry picking vitessio#13664 but there were a lot of conflicts to resolve and it wasn't straightforward.
Instead, this PR picks out the minimally needed changes from that PR to fix our existing build issues. This is different from #152 since it's still using the same "type" of fix that is present upstream (update all images to use bullseye instead of having to handle bullseye and buster type images in
install_dependencies.sh).Note: This does mean that mysql57 builds will no longer work but we don't want to build mysql57 anymore so that's acceptable.
🎩 'd: Successful build here