Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small typo fixes and additions #259

Merged
merged 5 commits into from
Aug 31, 2024

Conversation

nasbench
Copy link
Member

@nasbench nasbench commented Aug 13, 2024

This PR adds/updates the following:

  • Fixes some typos and messages wording.
  • Reorders the modifier_mapping dict for ease of reading.
  • Adds a new related type CORRELATION as suggested by Add correlation (or similar) related type sigma-specification#136. (The specification part is in progress). I think its an easy and useful add.
  • Remove the date check for dates yyyy/mm/dd in the SigmaRulesBase class to conform with the specs v2
  • Add exception handling for parsing sigma validation config file. (in case the file provided isn't a proper yaml)

@nasbench nasbench removed the request for review from thomaspatzke August 13, 2024 22:12
@nasbench nasbench marked this pull request as draft August 13, 2024 22:13
@nasbench nasbench marked this pull request as ready for review August 13, 2024 22:18
Copy link
Member

@frack113 frack113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaspatzke thomaspatzke merged commit 1b87cfa into SigmaHQ:main Aug 31, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants