Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taking into account Specification V2 #261

Closed
wants to merge 1 commit into from
Closed

Taking into account Specification V2 #261

wants to merge 1 commit into from

Conversation

frack113
Copy link
Member

Taking into account Specification V2 :

class SigmaRuleBase:

  • use the "rule_xx" pattern for level and status
  • Check date with - before / now
  • order field like the Specification (easier for newcomers) , add missing title in the tests

@frack113 frack113 marked this pull request as draft August 16, 2024 05:32
@frack113
Copy link
Member Author

Waiting for PR #259

@frack113
Copy link
Member Author

frack113 commented Sep 1, 2024

Too much conflicts
Cover by #269

@frack113 frack113 closed this Sep 1, 2024
@frack113 frack113 deleted the enforece_v2 branch September 8, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@frack113