Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature] language available as an option #171

Conversation

amauryfischer
Copy link

@amauryfischer amauryfischer commented Apr 4, 2023

What do you think of an option like this to enable language support ?

@amauryfischer amauryfischer marked this pull request as ready for review April 5, 2023 07:59
Copy link

@chillout222 chillout222 Apr 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def __init__(self):
    self.continuous_mode = False
    self.speak_mode = False
    self.language = None       # Add this line

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't get the program to speak Swedish though. Trying both -- sv and -- swedish as an option to start the program but it still speaks english. python main.py --language swedish

Copy link

@chillout222 chillout222 Apr 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this in prompt.txt:
3. Reflect in swedish on past decisions and strategies to refine your approach.

Ensure the response can be parsed by Python json.loads
Ensure to use swedish language to use Google Search and Browse Website

Copy link
Contributor

@nponeccop nponeccop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I guess more prompt engineering is needed to ensure that it works reliably. I can test Russian, Ukrainian and Spanish if necessary.

This was referenced Apr 10, 2023
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 17, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@Pwuts Pwuts added the internationalization Multi-language support label Apr 20, 2023
@p-i-
Copy link
Contributor

p-i- commented May 5, 2023

This is a mass message from the AutoGPT core team.
Our apologies for the ongoing delay in processing PRs.
This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to:
https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

@gravelBridge gravelBridge added this to the v0.3.3 Release milestone May 16, 2023
@gravelBridge
Copy link
Contributor

Hey, please fix merge conflicts.

@@ -284,6 +290,8 @@ def parse_arguments():
while True:
# Send message to AI, get response
with Spinner("Thinking... "):
if cfg.language:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the right place for this to live

Copy link
Member

@ntindle ntindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't configure prompt language from the main.

Add Tests
Add challenge

@ntindle ntindle added Needs Benchmark This change is hard to test and requires a benchmark and removed conflicts Automatically applied to PRs with merge conflicts labels Jun 7, 2023
@ntindle
Copy link
Member

ntindle commented Jun 7, 2023

@merwanehamadi how would a challenge for this work?

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jun 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@lc0rp lc0rp modified the milestones: v0.4.1 Release, v0.4.2 Release Jun 14, 2023
@lc0rp
Copy link
Contributor

lc0rp commented Jun 23, 2023

Don't configure prompt language from the main.
Add Tests
Add challenge
@amauryfischer Please address these comments if you're still interested in getting this in.

@lc0rp lc0rp modified the milestones: v0.4.3 Release, v0.4.4 Release Jun 23, 2023
@lc0rp lc0rp modified the milestones: v0.4.4 Release, v0.4.5 Jul 4, 2023
@lc0rp lc0rp modified the milestones: v0.4.5 Release, v0.4.6 Release Jul 14, 2023
@lc0rp lc0rp modified the milestones: v0.4.6 Release, v0.4.7 Release Jul 22, 2023
@lc0rp lc0rp modified the milestones: v0.4.7 Release, v0.4.8 Aug 1, 2023
@Pwuts Pwuts closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Automatically applied to PRs with merge conflicts internationalization Multi-language support Needs Benchmark This change is hard to test and requires a benchmark Obsolete?
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants